Skip to content

Conversation

jinapurapu
Copy link
Contributor

@jinapurapu jinapurapu commented May 5, 2023

Adds a Help Button to screen headers, which opens a Help Menu containing links to relevant documentation, videos and blogs.
Screen Shot 2023-05-23 at 3 26 03 PM

Screen Shot 2023-05-23 at 3 25 09 PM Screen Shot 2023-05-23 at 3 25 03 PM Screen Shot 2023-05-23 at 3 24 51 PM

Closes https://github.com/miniohq/engineering/issues/1045

@jinapurapu jinapurapu added the WIP This PR is WIP and cannot be merged yet label May 5, 2023
@jinapurapu jinapurapu self-assigned this May 5, 2023
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I'll work on design adjustments so it fits better the overall UI and style on a different PR.

@oscarocastellanos
Copy link

@jinapurapu Opened up this to help with the design of the menu.

@jinapurapu jinapurapu force-pushed the console_help_menu_1 branch 3 times, most recently from 6b669a6 to 10b7a0d Compare May 24, 2023 19:28
@jinapurapu jinapurapu removed the WIP This PR is WIP and cannot be merged yet label May 25, 2023
dvaldivia
dvaldivia previously approved these changes May 26, 2023
@jinapurapu jinapurapu force-pushed the console_help_menu_1 branch 2 times, most recently from de532fa to d5cbfdc Compare May 30, 2023 16:23
@jinapurapu jinapurapu force-pushed the console_help_menu_1 branch from d5cbfdc to 53d483b Compare June 5, 2023 19:54
Improved HelpMenu to stay op top

Added close on click outside to HelpMenu

WIP tab specific help in bucket details

Added helpName field

Changed PageHeaders to use new HelpMenu component

Added HelpMenu action and helpName tag to all PageHeaders

Added bucket_detail tab to helpName

Added helpName to systemSlice, used systemHelpName to pass active tab to helpMenu in UserDetails

Simplified HelpMenu component, WIP redux tab state

Fixed first load tab help for UserDetails

Made assets

Added help menu to event notification, ldap, call home screens

Added doc links for policies, buckets

Added more help doc links to tags

Added more help topics

Added HelpMenu

Improved HelpMenu to stay op top

Added close on click outside to HelpMenu

WIP tab specific help in bucket details

Added helpName field

Changed PageHeaders to use new HelpMenu component

Added HelpMenu action and helpName tag to all PageHeaders

Added bucket_detail tab to helpName

Added helpName to systemSlice, used systemHelpName to pass active tab to helpMenu in UserDetails

Simplified HelpMenu component, WIP redux tab state

Fixed first load tab help for UserDetails

Made assets

Added help menu to event notification, ldap, call home screens

Modified links to open in new tab

Added tabs to helpMenu

Added Docs, Video and Blog tags for HelpItems

Disabled empty helpmenu tabs

Stuff

Removed extra refresh on bucketdetails

Changed HelpMenu to use Tabs to avoid issues with VerticalTabs

Added content to TabPanels

Cleaned up help topics

Fixed empty Blog content tab when no Video

Added helpTabName to systemSlice, added default help case

Added help icon, formatting to help menu title

Added thumbnails

Added thumbnail links for docs and blog helpitems

Added video thumbnail links

Simplified HelpMenu header

Changed to use redux for tabs - working

Fixed tabs for User details

Changed all HelpMenus to use redux helpname

Cleanup of debugging lines

Prettier

removed debugging line

Added snippet text to list_policies

Added react-markdown to package.json, snippets

Updated dependencies

Fixed react warnings, snippets, content

Added tab specific help to Configuration Setting screen

Improved HelpMenu type tabs, settings content

Prettier

Removed unused variables

Removed unused variables

Replaced required variable

Prettier, clean up some helptopics

Yarn upgrade

Added Settings content and snippets

Added snippets

Stuff

Tweaks to help Menu

Signed-off-by: Daniel Valdivia <[email protected]>

Small Fixes

Signed-off-by: Daniel Valdivia <[email protected]>

Added missing text snippets, removed HelpMenu from login page, debugging line

Prettier

fixed react warnings

Prettier

Fixed tabbed screens

Removed unused imports

Minor fixes

Removed unused import

Resolved conflict
@jinapurapu jinapurapu force-pushed the console_help_menu_1 branch from 10ea16f to 64532f3 Compare June 8, 2023 14:02
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just need to review the Visio MinIO Videos link as it points to a 404 page right now.

Screenshot 2023-06-12 at 15 43 40

@dvaldivia dvaldivia merged commit 9fa49b4 into minio:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants