Skip to content

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Apr 29, 2023

What does this do?

  • Implemented new Embeddable Object Browser theming system
  • Adjusted & fixed some style issues in Object Browser
  • Fixed LegalHold & Retention screens

How to Test

For Common Console instance

Just run Console as you usually do

For Embeddable Object Browser

  • Do Make assets
  • Replace console in MinIO binary with this version
  • Start browser in embedded mode, include one more query param called ov_st which will contain a base64 encoded string of the following JSON:
{
  "backgroundColor": "#1c1c1c",
  "fontColor": "white",
  "secondaryFontColor": "grey",
  "borderColor": "yellow",
  "loaderColor": "red",
  "boxBackground": "#0579af",
  "okColor": "#08af05",
  "errorColor": "#bf1e46",
  "warnColor": "#bfac1e",
  "linkColor": "#1ebfbf",
  "disabledLinkColor": "#9da0a0",
  "hoverLinkColor": "#0f4ebc",
  "tableColors": {
    "border": "#4bbc0f",
    "disabledBorder": "#728e63",
    "disabledBG": "#728e63",
    "selected": "#55db0d",
    "deletedDisabled": "#eab6d0",
    "hoverColor": "#00fff6"
  },
  "buttonStyles": {
    "backgroundColor": "#0073ff",
    "textColor": "#ffffff",
    "hoverColor": "#2b8eff",
    "hoverText": "#fff",
    "activeColor": "#3883d8",
    "activeText": "#fff",
    "disabledColor": "#758e8d",
    "disabledText": "#d9dddd"
  },
  "secondaryButtonStyles": {
    "backgroundColor": "#ea3379",
    "textColor": "#ea3379",
    "hoverColor": "#ea3300",
    "hoverText": "#ea3300",
    "activeColor": "#ea3379",
    "activeText": "#3cea33",
    "disabledColor": "#787c77",
    "disabledText": "#787c77"
  },
  "regularButtonStyles": {
    "backgroundColor": "#0073ff",
    "textColor": "#0073ff",
    "hoverColor": "#2b8eff",
    "hoverText": "#0073ff",
    "activeColor": "#3883d8",
    "activeText": "#0073ff",
    "disabledColor": "#758e8d",
    "disabledText": "#d9dddd"
  },
  "inputBox": {
    "border": "green",
    "hoverBorder": "blue",
    "textColor": "white",
    "backgroundColor": "#28d4ff"
  },
  "switch": {
    "switchBackground": "#28d4ff",
    "bulletBorderColor": "#a6acad",
    "bulletBGColor": "#dce1e2",
    "disabledBackground": "#474949",
    "disabledBulletBorderColor": "#474949",
    "disabledBulletBGColor": "#7397a0"
  }
}

How does it look?

Screenshot 2023-04-29 at 12 01 01

Screenshot 2023-04-29 at 12 00 45

Screenshot 2023-04-29 at 12 00 38

Screenshot 2023-04-29 at 12 00 34

Screenshot 2023-04-29 at 12 00 28

Screenshot 2023-04-29 at 11 58 58

Screenshot 2023-04-29 at 11 58 51

Screenshot 2023-04-29 at 11 58 35

Screenshot 2023-04-29 at 11 58 32

Screenshot 2023-04-29 at 11 58 26

Screenshot 2023-04-29 at 11 58 23

Screenshot 2023-04-29 at 11 58 20

Screenshot 2023-04-29 at 11 57 40

@harshavardhana
Copy link
Member

Please rebase the PR @bexsoft

@bexsoft bexsoft force-pushed the update-main-styling branch from 01dfa58 to c61c3d6 Compare May 1, 2023 20:58
- Implemented new Embeddable Object Browser theming system
- Adjusted & fixed some style issues in Object Browser
- Fixed LegalHold & Retention screens

Signed-off-by: Benjamin Perez <[email protected]>
@bexsoft bexsoft force-pushed the update-main-styling branch from c61c3d6 to a054723 Compare May 2, 2023 17:13
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks amazing the dark mode 👍

Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally both embedded and stand alone and works great!

@bexsoft bexsoft added the blocked label May 2, 2023
@bexsoft bexsoft changed the title Changed Object Browser components to use new mds components [Block] Changed Object Browser components to use new mds components May 2, 2023
@bexsoft bexsoft changed the title [Block] Changed Object Browser components to use new mds components [Blocked] Changed Object Browser components to use new mds components May 2, 2023
@bexsoft bexsoft changed the title [Blocked] Changed Object Browser components to use new mds components Changed Object Browser components to use new mds components May 3, 2023
@bexsoft bexsoft removed the blocked label May 3, 2023
@harshavardhana harshavardhana merged commit be60569 into minio:master May 3, 2023
@bexsoft bexsoft deleted the update-main-styling branch May 3, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants