Disabled Preview button for text files #2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
jinapurapu and
dilverse
reivaj05
previously approved these changes
Feb 23, 2023
jinapurapu
previously approved these changes
Feb 23, 2023
bexsoft
dismissed stale reviews from jinapurapu, allanrogerr, and reivaj05
via
9d1a715
Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
force-pushed
the
disable-peview-button
branch
from
9d1a715 to
ee97704
Compare
allanrogerr
approved these changes
Feb 23, 2023
jinapurapu
approved these changes
Feb 23, 2023
|
Why exactly has the preview been disabled? |
|
What was the reasoning behind this decision? I find the preview option very useful for plain text files as it means I can upload a |
|
I'm trying to find out as well :D. I'm also curious about it. We'll share the context if we end up figuring out. but seems it was for security reasons but the reasons are not explained though. #2021 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Disabled Preview button for text files