[Feature] according to es2.0 spec, you must use clamp-to-edge as tex… #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure wrap mode, and no mipmapping for non-power-of-two texture
minggo
reviewed
Nov 22, 2018
| SamplerFilter minFilter = SamplerFilter::LINEAR; | ||
| SamplerFilter mipmapFilter = SamplerFilter::LINEAR; | ||
| SamplerAddressMode sAddressMode = SamplerAddressMode::REPEAT; | ||
| SamplerAddressMode tAddressMode = SamplerAddressMode::REPEAT; |
There was a problem hiding this comment.
It is ok to change default value, but we should do some protection of the usage in Texture.
…or non-power-of-two texture
minggo
reviewed
Nov 22, 2018
|
|
||
| CC_BACKEND_BEGIN | ||
|
|
||
| #define ISPOW2(n) (((n)&(n-1)) == 0) |
There was a problem hiding this comment.
It is better to define it in .cpp file.
minggo
reviewed
Nov 22, 2018
| GLint ret = GL_REPEAT; | ||
| GLint ret = GL_CLAMP_TO_EDGE; | ||
| if(!bPow2) | ||
| return ret; |
There was a problem hiding this comment.
It is better to output a log to say that the address mode is changed to GL_GLAMP_TO_EDGE.
minggo
reviewed
Nov 22, 2018
| { | ||
| if(!bPow2) | ||
| { | ||
| cocos2d::log("Disable mipmap since non-power-of-two texture occur in %s %s %d", __FILE__, __FUNCTION__, __LINE__); |
There was a problem hiding this comment.
It is better to say that what filter is used instead.
minggo
reviewed
Nov 22, 2018
| glGenTextures(1, &_texture); | ||
| toGLTypes(); | ||
|
|
||
| bool bPow2 = ISPOW2(_width) && ISPOW2(_height); |
There was a problem hiding this comment.
We don't use Hungary style, so it is better to change to isPow2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ture wrap mode, and no mipmapping for non-power-of-two texture