Skip to content

Add options to meta #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add options to meta #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496f363
Add options to meta
porfirioribeiro Jun 27, 2017
6ce142d
Only add options if it has any
porfirioribeiro Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/gen/js/genReduxActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import * as ${name} from '../${name}'${ST}
function renderReduxActionBlock(spec: ApiSpec, op: ApiOperation, options: ClientOptions): string {
const lines = []
const isTs = options.language === 'ts'
let hasOptions=''
const actionStart = camelToUppercase(op.id) + '_START'
const actionComplete = camelToUppercase(op.id)
const infoParam = isTs ? 'info?: any' : 'info'
Expand All @@ -45,6 +46,7 @@ function renderReduxActionBlock(spec: ApiSpec, op: ApiOperation, options: Client
const required = op.parameters.filter(param => param.required)
let params = required.map(param => param.name).join(', ')
if (required.length < op.parameters.length) {
hasOptions=', options'
if (required.length) params += ', options'
else params = 'options'
}
Expand All @@ -58,15 +60,15 @@ ${isTs ? `export type ${actionComplete} = ${returnType}${ST}`: ''}

export function ${op.id}(${paramSignature})${isTs? ': any' : ''} {
return dispatch => {
dispatch({ type: ${actionStart}, meta: { info } })${ST}
dispatch({ type: ${actionStart}, meta: { info${hasOptions} } })${ST}
return ${op.group}.${op.id}(${params})
.then(response => dispatch({
type: ${actionComplete},
payload: response.data,
error: response.error,
meta: {
res: response.raw,
info
info${hasOptions}
}
}))${ST}
}${ST}
Expand Down