Skip to content

Conversation

@smskin
Copy link
Contributor

@smskin smskin commented Feb 16, 2018

Need add "NotIn" element to array in getTypeClause method

Need add "NotIn" element to array in getTypeClause method
@mikebronner
Copy link
Owner

Please also provide a unit test that addresses this specific issue. If you're not sure how, I can add it before merging in your PR. Any issues should be replicated by a failing test, before being fixed, so that the code is protected from that issue going forward. :)

Repository owner deleted a comment from coveralls Feb 16, 2018
@mikebronner mikebronner self-requested a review February 16, 2018 15:56
@mikebronner mikebronner removed their request for review February 16, 2018 16:21
@mikebronner mikebronner merged commit 9cbfac8 into mikebronner:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants