Skip to content

Fix the invalid token bug for default github instances #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Fix the invalid token bug for default github instances #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/analytics_server/mhq/utils/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ def run(self):


def get_custom_github_domain(org_id: str) -> Optional[str]:
DEFAULT_DOMAIN = "https://api.github.com"
core_repo_service = CoreRepoService()
integrations = core_repo_service.get_org_integrations_for_names(
org_id, [UserIdentityProvider.GITHUB.value]
Expand All @@ -70,6 +69,8 @@ def get_custom_github_domain(org_id: str) -> Optional[str]:
LOG.warn(
f"Custom domain not found for intergration for org {org_id} and provider {UserIdentityProvider.GITHUB.value}"
)
return DEFAULT_DOMAIN
# return nothing when custom domain is not found
# this is to prevent the default domain from being used
return

return github_domain