-
Notifications
You must be signed in to change notification settings - Fork 193
Handle UI Freezes when IMGR is called from WPF #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peombwa
reviewed
Oct 26, 2020
src/Authentication/Authentication/Cmdlets/InvokeMgGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeMgGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeMgGraphRequest.cs
Outdated
Show resolved
Hide resolved
peombwa
previously approved these changes
Oct 28, 2020
peombwa
reviewed
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the UI freeze also happens with Connect-MgGraph
when called with -ForceRefresh
. Consider using NoSynchronizationContext
with Connect-MgGraph
as well.
Here is a repro of the same :
Add-Type -AssemblyName PresentationFramework
[xml]$xaml = @"
<Window
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
Title="Window" Height="200" Width="300">
<Grid Background="#FFECECEC">
<Button Name="button1" Content="Connect-MgGraph" HorizontalAlignment="Left" Margin="10,10,10,10" VerticalAlignment="Top"/>
<Button Name="button2" Content="Connect-MgGraph -ForceRefresh" HorizontalAlignment="Left" Margin="10,30,10,10" VerticalAlignment="Top"/>
<Button Name="button3" Content="Invoke-GraphRequest" HorizontalAlignment="Left" Margin="10,50,10,10" VerticalAlignment="Top"/>
</Grid>
</Window>
"@
$reader = (New-Object System.Xml.XmlNodeReader $xaml)
$window = [Windows.Markup.XamlReader]::Load($reader)
$button1 = $window.FindName("button1")
$button1.Add_Click( {
write-host (Connect-MgGraph | out-string)
})
$button2 = $window.FindName("button2")
$button2.Add_Click( {
write-host (Connect-MgGraph -ForceRefresh | out-string)
})
$button3 = $window.FindName("button3")
$button3.Add_Click( {
write-host (Invoke-GraphRequest -uri "https://graph.microsoft.com/v1.0/users" | out-string)
})
$window.ShowDialog()
Make methods private.
peombwa
previously approved these changes
Nov 16, 2020
peombwa
reviewed
Nov 18, 2020
peombwa
approved these changes
Nov 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use asynccommandruntime to handle async calls.
Fix double formatted resource strings.
Testing
Client was using the script references in issue #390
Local testing using client script shows the freezes no longer occur.
Fixes #436
Fixes #390