Update org in reference repo #194415
Merged
Update org in reference repo #194415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This threw me off in microsoft#194352 -- I was not familiar with the original repo owner so I assumed this info was stale. The link now redirects to the REditorSupport org, but having the correct source in the plain text is still preferable for human readers.
alexr00
requested changes
Sep 29, 2023
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
@MichaelChirico your change makes sense, but that file is generated via script. To update that line in the script, this is actually what needs to be updated:
Contributor
Author
|
Thanks; done. I also checked Lines 595 to 596 in b86e7bc vscode/extensions/r/cgmanifest.json Lines 7 to 8 in b86e7bc Shall we update either of those usages while we're at it? |
Contributor
Author
|
@microsoft-github-policy-service agree company="Google" |
alexr00
approved these changes
Oct 2, 2023
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thanks for catching, I made the last update. We will take care of the ThirdPartyNotices.txt update as part of our release process.
Thanks for the PR!
aeschli
approved these changes
Oct 2, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
* Update org in reference repo This threw me off in microsoft#194352 -- I was not familiar with the original repo owner so I assumed this info was stale. The link now redirects to the REditorSupport org, but having the correct source in the plain text is still preferable for human readers. * Update template generation source * Update R repo in cgmanifest --------- Co-authored-by: Alex Ross <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This threw me off in #194352 -- I was not familiar with the original repo owner so I assumed this info was stale. The link now redirects to the REditorSupport org, but having the correct source in the plain text is still preferable for human readers.