Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

High contrast theme bugs #286

@hawkticehurst

Description

@hawkticehurst

Describe the bug

There are a handful of component theming bugs when the VS Code high contrast theme is applied.

To reproduce

  • Install and run the all-components sample extension
  • Set the VS Code theme to High Contrast
  • View the various visual states of buttons, dropdowns, and data grids

Expected behavior

Buttons, dropdowns, and data grids should adhere to/match the visual states of native VS Code buttons, dropdowns, and data grids.

Screenshots

Incorrect button backgrounds:

Screen Shot 2021-11-01 at 5 24 52 PM

Correct button backgrounds:

Screen Shot 2021-11-01 at 5 24 48 PM

Incorrect icon button default state:

Screen Shot 2021-11-02 at 2 47 08 PM

Correct icon button default state:

Screen Shot 2021-11-02 at 2 47 22 PM

Incorrect icon button hover state:

Screen Shot 2021-11-02 at 2 47 16 PM

Correct icon button hover state:

Screen Shot 2021-11-02 at 2 47 39 PM

Incorrect dropdown option selected state:

Screen Shot 2021-11-02 at 2 46 18 PM

Correct dropdown option selected state:

Screen Shot 2021-11-02 at 2 46 35 PM

Incorrect data grid selected/hover state:

Screen Shot 2021-11-02 at 2 45 48 PM

Correct data grid selected/hover state:

Screen Shot 2021-11-02 at 2 46 01 PM

Desktop (please complete the following information):

  • OS Version: macOS 11.6
  • Toolkit Version: v0.8.3

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions