Skip to content

Track if jupyter is not installed in current env #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2019
Merged

Track if jupyter is not installed in current env #8370

merged 3 commits into from
Nov 4, 2019

Conversation

DonJayamanne
Copy link

For #8369

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Nov 4, 2019
@codecov-io
Copy link

codecov-io commented Nov 4, 2019 •
edited
Loading

Codecov Report

Merging #8370 into master will decrease coverage by <.01%.
The diff coverage is 65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8370      +/-   ##
==========================================
- Coverage   59.39%   59.38%   -0.01%     
==========================================
  Files         508      508              
  Lines       23236    23247      +11     
  Branches     3750     3754       +4     
==========================================
+ Hits        13800    13806       +6     
- Misses       8540     8545       +5     
  Partials      896      896
Impacted Files Coverage Δ
src/client/datascience/constants.ts 100% <100%> (ø) ⬆️
src/client/telemetry/index.ts 86.13% <100%> (ø) ⬆️
...client/datascience/jupyter/jupyterCommandFinder.ts 73.62% <100%> (+1.53%) ⬆️
...atascience/interactive-window/interactiveWindow.ts 22.22% <12.5%> (-1.7%) ⬇️
src/client/terminals/codeExecution/helper.ts 21.27% <0%> (-0.73%) ⬇️
src/client/testing/navigation/symbolProvider.ts 93.1% <0%> (-0.65%) ⬇️
src/client/common/utils/localize.ts 93.99% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b202ad2...a56614e. Read the comment docs.

rchiodo
rchiodo previously approved these changes Nov 4, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo dismissed their stale review November 4, 2019 21:50

revoking review

rchiodo
rchiodo reviewed Nov 4, 2019
View reviewed changes
rchiodo
rchiodo requested changes Nov 4, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@DonJayamanne DonJayamanne requested a review from rchiodo November 4, 2019 22:14
rchiodo
rchiodo approved these changes Nov 4, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
Copy link
Author

CI fell over.

@DonJayamanne DonJayamanne reopened this Nov 4, 2019
@DonJayamanne DonJayamanne merged commit 700bc48 into microsoft:master Nov 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 12, 2019
@DonJayamanne DonJayamanne deleted the issue8369 branch November 15, 2019 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo