Skip to content

Predictable ids for Conda envs without Python #20496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Predictable ids for Conda envs without Python #20496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/client/pythonEnvironments/base/locators/composite/resolverUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ export async function resolveBasicEnv(env: BasicEnvInfo): Promise<PythonEnvInfo>
await updateEnvUsingRegistry(resolvedEnv);
}
setEnvDisplayString(resolvedEnv);
resolvedEnv.id = getEnvID(resolvedEnv.executable.filename, resolvedEnv.location);
let fileName = resolvedEnv.executable.filename;
if (env.envPath && env.kind === PythonEnvKind.Conda && path.basename(fileName) === fileName) {
fileName =
getOSType() === OSType.Windows ? path.join(env.envPath, fileName) : path.join(env.envPath, 'bin', fileName);
}
resolvedEnv.id = getEnvID(fileName, resolvedEnv.location);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a valid approach, because the new env will take the place of this old env.
& worst case scenario, the id will be different from the old env, which is already the case, hence no harm

const { ctime, mtime } = await getFileInfo(resolvedEnv.executable.filename);
resolvedEnv.executable.ctime = ctime;
resolvedEnv.executable.mtime = mtime;
Expand Down