Skip to content

Remove debugger banner #19849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

farahInTheZone
Copy link

Problem

Issue Link

#19714

Summary

Remove debugger banner

Description

It was reported in the issue 19714 that we display a prompt to get feedback on a separate survey for the debugger, but given we get a lot of feedback for the debugger in our "general" survey, it should be fine to remove it.

Solution

Implementation

The current implementation of the debugger survey is defined in a banner class. This class pops up a banner to ask if the user wants to fill out the survey or not. If selected yes, a browser with the survey link is opened.
After discussing with the team, we decided to remove the banner completely, and if it is needed in the future the team will restore it.

Testing

Unit test

debugging-output.txt

@ghost
Copy link

ghost commented Sep 16, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ farahtk sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@luabud luabud requested a review from karthiknadig September 16, 2022 18:12
@karthiknadig karthiknadig added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Sep 16, 2022
@luabud
Copy link
Member

luabud commented Sep 16, 2022

@farahtk can you click the sign button here to accept our Contributor License Agreement? 😄

@farahInTheZone
Copy link
Author

@luabud waiting for my company to review and approve :)

@karthiknadig
Copy link
Member

karthiknadig commented Sep 16, 2022

@luabud @farahtk is waiting on their company guidance for CLA.

@karthiknadig
Copy link
Member

@farahtk Any update on the CLA?

@farahInTheZone
Copy link
Author

farahInTheZone commented Oct 11, 2022

@farahtk Any update on the CLA?

@karthiknadig got the approval to move forward

@karthiknadig
Copy link
Member

@farahtk I will close and re-open this issue to re-trigger CLA bot. Please sign the CLA, then we can continue to merge.

@farahInTheZone
Copy link
Author

@microsoft-github-policy-service agree

@karthiknadig karthiknadig merged commit 466139f into microsoft:main Oct 12, 2022
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
### Problem
#### Issue Link
microsoft/vscode-python#19714
#### Summary
Remove debugger banner
#### Description
It was reported in the issue 19714 that we display a prompt to get
feedback on a separate survey for the debugger, but given we get a lot
of feedback for the debugger in our "general" survey, it should be fine
to remove it.

### Solution
#### Implementation
The current implementation of the debugger survey is defined in a banner
class. This class pops up a banner to ask if the user wants to fill out
the survey or not. If selected yes, a browser with the survey link is
opened.
After discussing with the team, we decided to remove the banner
completely, and if it is needed in the future the team will restore it.
#### Testing
##### Unit test

[debugging-output.txt](https://github.com/microsoft/vscode-python/files/9586036/debugging-output.txt)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants