Skip to content

Remove prompt for debugger survey #19714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luabud opened this issue Aug 19, 2022 · 3 comments
Closed

Remove prompt for debugger survey #19714

luabud opened this issue Aug 19, 2022 · 3 comments
Assignees
@farahInTheZone
Labels
area-debugging debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue needs PR Ready to be worked on

Comments

@luabud
Copy link
Member

luabud commented Aug 19, 2022 •
edited
Loading

We display a prompt to get feedback on a separate survey for the debugger, but given we get a lot of feedback for the debugger in our "general" survey, it should be fine to remove it.

The code to be removed is here:

vscode-python/src/client/debugger/extension/banner.ts

Line 75 in 3698950

public async show(): Promise<void> {

@luabud luabud added the feature-request Request for new features or functionality label Aug 19, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 19, 2022
@luabud luabud added good first issue debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-debugging needs PR Ready to be worked on and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Aug 19, 2022
@luabud luabud mentioned this issue Aug 19, 2022
Closed
@ChinazoOnwukaike
Copy link

Can this be assigned to me please?

@farahInTheZone
Copy link

Would like to work on this

@farahInTheZone
Copy link

@luabud regarding the banner, do you think will this ever be used again for some other scenario? If the only use case is to use it for surveys, it would be safe to remove a bunch of code. Otherwise, it makes sense to just disable the default banner state for now and let the dead code stay for future. WDYT?

@farahInTheZone farahInTheZone mentioned this issue Sep 16, 2022
Merged
karthiknadig pushed a commit that referenced this issue Oct 12, 2022
@farahInTheZone
Remove debugger banner (#19849)
466139f 
### Problem
#### Issue Link
#19714 
#### Summary
Remove debugger banner
#### Description
It was reported in the issue 19714 that we display a prompt to get
feedback on a separate survey for the debugger, but given we get a lot
of feedback for the debugger in our "general" survey, it should be fine
to remove it.

### Solution
#### Implementation
The current implementation of the debugger survey is defined in a banner
class. This class pops up a banner to ask if the user wants to fill out
the survey or not. If selected yes, a browser with the survey link is
opened.
After discussing with the team, we decided to remove the banner
completely, and if it is needed in the future the team will restore it.
#### Testing
##### Unit test

[debugging-output.txt](https://github.com/microsoft/vscode-python/files/9586036/debugging-output.txt)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@farahInTheZone farahInTheZone

Labels
area-debugging debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karthiknadig @farahInTheZone @luabud @ChinazoOnwukaike