Skip to content

Move from Click to docopt for announce.py #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2018
Merged

Move from Click to docopt for announce.py #1806

merged 3 commits into from
May 31, 2018

Conversation

brettcannon
Copy link
Member

No description provided.

@brettcannon brettcannon requested a review from d3r3kk May 31, 2018 00:28
@codecov
Copy link

codecov bot commented May 31, 2018 •
edited
Loading

Codecov Report

Merging #1806 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1806   +/-   ##
======================================
  Coverage    74.1%   74.1%           
======================================
  Files         282     282           
  Lines       13089   13089           
  Branches     2335    2335           
======================================
  Hits         9700    9700           
  Misses       3259    3259           
  Partials      130     130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5f760...4174e6b. Read the comment docs.

d3r3kk
d3r3kk approved these changes May 31, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Having just spent time learning argparse I would have been cool with that one too (but I'm also a fan of using getopt as well, so yeah, take with grain of salt.)

@d3r3kk d3r3kk merged commit e2f8ee2 into microsoft:master May 31, 2018
@brettcannon brettcannon deleted the docopt branch May 31, 2018 17:40
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettcannon @d3r3kk