venv activation command (source ...) also run on shells where it makes no sense #22796
Description
Type: Bug
Behaviour
Expected vs. Actual
The source command shall not be run on any shells that don't support the source command.
Steps to reproduce:
- Add custom terminal profile (via settings.terminal.integrated.profiles.linux), in my case for a custom remote control terminal that has no similarities to bourne shells and can not run binaries anyway.
- Open a new terminal. The Python extension will now try to execute a source command in the terminal.
Diagnostic data
- Python version (& distribution if applicable, e.g. Anaconda): 3.11.2
- Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
- Value of the
python.languageServersetting: Default
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
2024-01-29 13:06:12.230 [info] Send text to terminal: source /root/.venv/bin/activate
User Settings
Multiroot scenario, following user settings may not apply:
languageServer: "Pylance"
testing
• cwd: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: true
Extension version: 2023.22.1
VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:19.222Z)
OS version: Linux x64 6.2.0-39-generic
Modes:
Connection to 'dev-container+7b22686f737450617468223a222f686f6d652f686161672f446576656c6f706d656e742f7170772e6f73222c22636f6e66696746696c65223a7b22246d6964223a312c22667350617468223a222f686f6d652f686161672f446576656c6f706d656e742f7170772e6f732f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c2265787465726e616c223a2266696c653a2f2f2f686f6d652f686161672f446576656c6f706d656e742f7170772e6f732f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c2270617468223a222f686f6d652f686161672f446576656c6f706d656e742f7170772e6f732f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c22736368656d65223a2266696c65227d7d' could not be established
Remote OS version: Linux x64 4.18.0-521.el8.x86_64
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Xeon(R) W-2125 CPU @ 4.00GHz (8 x 1199) |
| GPU Status | 2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off |
| Load (avg) | 2, 1, 1 |
| Memory (System) | 125.47GB (109.96GB free) |
| Process Argv | --unity-launch |
| Screen Reader | no |
| VM | 0% |
| DESKTOP_SESSION | plasma |
| XDG_CURRENT_DESKTOP | KDE |
| XDG_SESSION_DESKTOP | KDE |
| XDG_SESSION_TYPE | x11 |
Connection to 'dev-container+7b22686f737450617468223a222f686f6d652f686161672f446576656c6f706d656e742f7170772e6f73222c22636f6e66696746696c65223a7b22246d6964223a312c22667350617468223a222f686f6d652f686161672f446576656c6f706d656e742f7170772e6f732f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c2265787465726e616c223a2266696c653a2f2f2f686f6d652f686161672f446576656c6f706d656e742f7170772e6f732f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c2270617468223a222f686f6d652f686161672f446576656c6f706d656e742f7170772e6f732f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c22736368656d65223a2266696c65227d7d' could not be established
| Item | Value |
|---|---|
| Remote | Dev Container: qpw-build @ ssh://qpw-devil-100108 |
| OS | Linux x64 4.18.0-521.el8.x86_64 |
| CPUs | Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz (48 x 2900) |
| Memory (System) | 62.41GB (47.53GB free) |
| VM | 0% |