Spins forever when running test fails

[roblourens]

Type: Bug

Behaviour

Expected vs. Actual

I right clicked a test and clicked "Debug test". The test runner failed to start due to a misconfiguration. Then the spinner decoration on the test run entry spins forever.

Steps to reproduce:

1. Add a launch config like this:

        {
            "name": "Python: Debug Tests",
            "type": "python",
            "request": "launch",
            "module": "pytest",
            "args": "${file}",
            "purpose": [
                "debug-test"
            ],
            "console": "integratedTerminal"
        }

this is invalid because it has 'module'.

2. Run "debug test"
3. Get an error message
4. See test run spinner spin forever in the test explorer and test results view

Diagnostic data

• Python version (& distribution if applicable, e.g. Anaconda): 3.9.5
• Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
• Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

languageServer: "Pylance"

linting
• enabled: false

testing
• unittestArgs: "<placeholder>"
• unittestEnabled: true

Extension version: 2023.17.12491008
VS Code version: Code - Insiders 1.83.0-insider (df70309, 2023-09-06T21:44:44.629Z)
OS version: Darwin x64 22.6.0
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	5, 5, 5
Memory (System)	32.00GB (0.05GB free)
Process Argv	--enable-proposed-api isc-bsaviano.vscode-memfs --crash-reporter-id a2c1d522-e9f0-4e3f-b78a-9253f1c2d2d3
Screen Reader	no
VM	0%

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256197
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vsdfh931:30280409
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vscaac:30438845
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
2i9eh265:30646982
showlangstatbar:30737417
24365598:30687740
pythonfmttext:30716741
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
copilotsettingt:30808721
dsvsc013:30777762
dsvsc014:30777825
diffeditorv2:30786206
pythonlinttypecf:30823782
pythonmhint1:30815193
dsvsc015:30821418
pythontestfixt:30826906
pythonfb280951:30830809

[eleanorjboyd]

should be fixed by #21876

[ruimin-z]

Hello @eleanorjboyd, can I work on this issue?

[eleanorjboyd]

This issue needs to be verified with the new testing rewrite setting turned on:

You can check for it by looking at Experiment 'pythonTestAdapter' is active in your python logs. You can turn it on by adding this setting to your users settings.json "python.experiments.optInto": ["pythonTestAdapter"].

[ruimin-z]

I verify this issue is fixed when new testing rewrite setting is both turned on and off.