Update our calls to goto_assignments() for Jedi

[EvgeniyMakhmudov]

Environment data

• VS Code version: 1.21.0
• Extension version (available under the Extensions sidebar): 2018.2.1
• OS and version: Linux Mint 18.3
• Python version: 3.5
• Type of virtual environment used (if applicable): venv
• Relevant/affected Python packages and their versions:

Actual behavior

Go to definition of some used class not open file with it definition

Expected behavior

Go to definition of some used class open file with it definition

Steps to reproduce:

1. File a1.py have class Foo: pass
2. File b1.py have

from a1 import Foo
class Bar(Foo):pass

3. Click "go to definition" in file b1 on Foo, must open a1 file with definition of Foo, but moving cursor to first line with import of Foo
4. Downgrade to 2018.1.0 solve this problem

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

##########Linting Output - flake8##########
##########Linting Output - flake8##########

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

[/home/john_16/.vscode/extensions/donjayamanne.githistory-0.4.0]: Команда "git.viewFileHistory" встречается несколько раз в разделе commands.
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:257 [Extension Host] TypeDefinition null
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:257 [Extension Host] Extension "currenttodos" activated!
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:257 [Extension Host] vscode-icons is active!
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:257 [Extension Host] (node:23354) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:257

[PeterJCLaw]

This reproduces for me under Python 2, 3.5 and 3.6 (all virtualenvs on Ubuntu).

Notably on importing a1 as a whole module and referencing Foo as an attribute of that, going to the definition of Foo goes directly to the class definition in a1.py:

import a1
class Bar2(a1.Foo): pass

Separately, this bug feels reminiscent of https://github.com/DonJayamanne/pythonVSCode/issues/781 and https://github.com/DonJayamanne/pythonVSCode/issues/742; perhaps a fix might be found in a similar location?

[Varkal]

This reproduce for me on macOS python3.6.

[ocavue]

I found something that may help from here

This seems to be because the extension uses goto_definitions instead of goto_assignments when calling Jedi. Calling goto_assignments instead fixes this, but changes the behavior when going to an imported function.

i.e. with the current code clicking on bar in this code

from foo import bar

bar()

will jump to bar in the foo module, but if goto_assignments is used this will jump to the from foo import bar line.

I guess, vscode-python switch from goto_definitions to goto_assignments.

I think giving a setting option to choose between goto_definitions and goto_assignments is a better solution. (I like goto_definitions)

[brettcannon]

@ocavue we actually use both as necessary.

This appears to be a semantic change between Jedi 0.10.x and 0.11.x which we upgraded to in the 2018.2.0 release.

[ocavue]

@brettcannon you are right. I clone v0.9.0 Jedi and everything is fine. Thanks to python.jediPath setting.

[PeterJCLaw]

@brettcannon does that mean that there's now an open issue upstream for this? (I can't immediately see one, but would be happy to create one)

The jedi changelog doesn't note any changes around the goto* api methods in 0.11.x, it would be good to understand where you think the difference is?