Skip to content

Use @vscode/python-extension package #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

Use @vscode/python-extension package #144

merged 2 commits into from
Jul 25, 2023

Conversation

karthiknadig
Copy link
Member

Fixes #142

@karthiknadig karthiknadig requested a review from karrtikr July 25, 2023 22:43
@karthiknadig karthiknadig self-assigned this Jul 25, 2023
karrtikr
karrtikr previously approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure to test it out, LGTM otherwise.

@karthiknadig karthiknadig marked this pull request as ready for review July 25, 2023 23:18
@karthiknadig karthiknadig requested a review from karrtikr July 25, 2023 23:24
@karthiknadig karthiknadig enabled auto-merge (squash) July 25, 2023 23:24
@karthiknadig
Copy link
Member Author

The API works as expected. The only change here is how we get the API.

@karthiknadig karthiknadig merged commit fbecd1c into microsoft:main Jul 25, 2023
@karthiknadig karthiknadig deleted the use-api branch July 25, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@karthiknadig karthiknadig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt @vscode/python-extension to fetch Python extension API in all extensions which use the template
2 participants
@karthiknadig @karrtikr