Skip to content

[WIP] Migrate to vscode-test module #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

emtei
Copy link
Contributor

@emtei emtei commented Nov 1, 2019

Resolves #1430

I am still working on this, PR opened just to be able to test if CI builds are fine.
Still to do:

  • investigate warning [email protected]: The engine "vscode" appears to be invalid. warning
  • fix nvm is not compatible with the "npm_config_prefix" environment variable: currently set to "/usr/local" when running CI build

@emtei emtei marked this pull request as ready for review November 1, 2019 19:47
@emtei emtei changed the title Migrate to vscode-test module [WIP] Migrate to vscode-test module Nov 1, 2019
@IllusionMH
Copy link
Contributor

IllusionMH commented Nov 1, 2019

The engine "vscode" appears to be invalid. This is yarn warning that I haven't found a way to suppress.

VSCode uses "engines" > "vscode" entry from package.json to check for minimum allowed version for extension. Which is required according to docs

Maybe these link will be helpful for you
yarnpkg/yarn#1102
yarnpkg/rfcs#69

Checks are performed in this file and looks like there is no way to ignore vscode in engines checks with configuration. Only --ignore-engines flag during installation which will disable all engine checks

@emtei emtei closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to vscode-test module
2 participants