-
Notifications
You must be signed in to change notification settings - Fork 673
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugverifiedVerification succeededVerification succeeded
Milestone
Description
- Extension version: 0.116.1
- VSCode Version: 1.104.0-insider
- OS: Mac OS 15.6
- Repository Clone Configuration (single repository/fork of an upstream repository): ?
- GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): GirHub.com
Steps to Reproduce:
- have a PR which has been reviewed and approved, but has comments
- Use GitHub Copilot in Agent mode to request that it make changes based on the comments on the active PR
- Observe that it successfully returns the PR details with description, status check, file diffs, etc, but the comments array is empty
Example comment from the PR:
(Shortened) Output from the command:
{
"title": "BMAPS-2859 - Implement FeatureGrid column deletion functionality",
"body": "## Issue Link\r\n[BMAPS-2859](https://northpoint-development.atlassian.net/browse/BMAPS-2859)\r\n\r\n## Description\r\nThis PR implements the column deletion functionality for the FeatureGrid component, allowing users to delete entire columns (display fields) from features and comps in the data table.\r\n\r\n**Key Features:**\r\n- Added column deletion UI with confirmation dialog\r\n- Implements batch deletion of display fields across features and comps\r\n- Includes proper error handling and user feedback\r\n- Supports both feature-level and comp-level field deletion\r\n- Respects the allowDelete property on display fields for UI visibility\r\n\r\n## Tests\r\nTo test the column deletion functionality:\r\n1. Navigate to a map with features that have display fields\r\n2. Open the FeatureGrid (data table view)\r\n3. Switch to 'Edit' mode using the view mode toggle\r\n4. Look for deletable column headers (those with a trash/delete icon)\r\n5. Click the delete icon on any deletable column\r\n6. Confirm the deletion in the popup dialog\r\n7. Verify the column and all associated fields are removed from the table\r\n8. Test with both regular features and comp data to ensure both work correctly\r\n9. Verify that columns with non-deletable fields do not show delete icons\r\n\r\n## Checklist\r\n- [x] My pull request title matches the following format: BMAPS-2859 - Implement FeatureGrid column deletion functionality\r\n- [x] I added/updated tests for the changes I made\r\n- [x] I have run `npm audit fix` until all vulnerabilities that can be automatically fixed are fixed\r\n- [x] I added or updated documentation/README\r\n- [x] All tests are passing (23/23 unit tests, E2E tests updated)\r\n\r\n[BMAPS-2859]: ",
"author": {
"login": "samschurter",
"url": "https://github.com/samschurter",
"avatarUrl": "https://avatars.githubusercontent.com/u/7039470?v=4",
"email": "[email protected]",
"id": "=",
"name": "Sam Schurter",
"accountType": "User"
},
"comments": [],
"state": "OPEN",
"statusChecks": [
{
"context": "dependabot-automerge",
"description": null,
"state": "neutral",
"name": "Auto-Merge Dependabot PR",
"targetUrl": "https://github.com/northpoint-development/Beyond-Maps/actions/runs/16914977056/job/47926459827"
}
],
"reviewRequirements": {
"approvalsNeeded": 0,
"currentApprovals": 0,
"areChangesRequested": false
},
"isDraft": "false",
"codingAgentSession": [],
"changes": [
"@@ -134,6 +134,12 @@ procedures/ # BigQuery stored procedures\n - Include proper error handling and logging\n - Test with Firebase Functions Emulator\n \n+## Pull Requests\n+- Pull request titles must follow the format \"BMAPS-<JIRA_ID> <Description>\"\n+- Pull request descriptions must follow the [pull request template](./PULL_REQUEST_TEMPLATE.md)\n+- Always read the pull request template before filling it in.\n+- You do not have the ability to include screenshots, and they are optional in the template. Do not include the screenshot section.\n+\n ## Important Notes\n \n ### Vuetify UI Components"
]
}Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugverifiedVerification succeededVerification succeeded