Skip to content

Conversation

@mattmasson
Copy link
Member

@mattmasson mattmasson commented Jan 25, 2024

Resolves many npm package dependency issues.

There are still some warnings about deprecated packages (eslint and babel) under the webviews directory. These are tracked by #295

@albertli-msft
Copy link
Contributor

One last thing 😬, let's bump the node version used in the pl yml as well:

.github/workflows/pr-gated.yml
L16: node-version: "16.14" -> node-version: "18.19"

.pipelines/pr-pipeline.yml
L20: versionSpec: "16.x" -> versionSpec: "18.x"

.github/workflows/rc.yml
L57: node-version: "16.14" -> node-version: "18.19"

Copy link
Contributor

@albertli-msft albertli-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh, we forgot the pl ymls

@mattmasson
Copy link
Member Author

I noticed that changing node versions and the version of vscode-extension-tester would typically cause test:e2e to fail with an error like:

"This version of \test-resources\VSCode-win32-x64-archive\Code.exe is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher."

Deleting the files under the test-resources path seemed to resolve the issue.

@mattmasson mattmasson merged commit f5c614b into main Jan 26, 2024
@mattmasson mattmasson deleted the dev/updateDependencies branch January 26, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants