Skip to content

fix. open flags to support arm64 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix. open flags to support arm64 #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a65ee1
fix. open flags to allow supporting arm64
albertli-msft Feb 16, 2023
6f01953
Localized file check-in by OneLocBuild Task: Build definition ID 585:…
albertli-msft Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion localize/i18n/cs/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/de/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/es/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/fr/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/it/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/ja/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/ko/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/pl/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/pt-br/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/ru/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/tr/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/zh-cn/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion localize/i18n/zh-tw/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion src/i18n/extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"PQSdk.common.logLevel.Trace": "Trace",
"PQSdk.common.logLevel.Info": "Info",
"PQSdk.common.logLevel.Error": "Error",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64",
"PQSdk.boostrap.unsupported.arch": "Unsupported platform or architecture found, currently Power query SDK would only support Windows x86_64 or arm64",
"PQSdk.debugger.error.cannot.find.program": "Cannot find a program to debug",
"PQSdk.lifecycle.command.update.lastCtimeOfMezFile": "Update last ctime of an inferred mez file to {lastCtimeOfMezFileWhoseInfoSeized}",
"PQSdk.lifecycle.command.detect.newerMezFile": "Detected a newer mez file, about to infer its latest info. {currentCtime}, {diffCtime}",
Expand Down
2 changes: 1 addition & 1 deletion src/utils/osUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ export function isSupportedOs(): boolean {
const platform: string = os.platform();
const arch: string = os.arch();

return platform === "win32" && arch === "x64";
return platform === "win32" && (arch === "x64" || arch === "arm64");
}