Skip to content

enhance PqSdkNugetPackageService #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2022
Merged

enhance PqSdkNugetPackageService #144

merged 4 commits into from
Oct 10, 2022

Conversation

@albertli-msft
Copy link
Contributor

@albertli-msft albertli-msft commented Oct 7, 2022 •
edited
Loading

  • create PqSdkNugetPackageService.ts and remove PqSdk relating codes out of LifecycleCommands.ts for the better readability; and i still thought it would be much better to avoid inherit PqSdkNugetPackageService from lifecycleCommand
  • create unit tests for it associated NugetCommandService and NugetHttpService

@mattmasson mattmasson merged commit 0414a6a into main Oct 10, 2022
@mattmasson mattmasson deleted the dev/albertli/enhance-nuget-svc branch October 10, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmasson mattmasson mattmasson approved these changes

@JordanBoltonMN JordanBoltonMN Awaiting requested review from JordanBoltonMN

@ptyx507x ptyx507x Awaiting requested review from ptyx507x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albertli-msft @mattmasson