Skip to content

Conversation

@tanhakabir
Copy link
Contributor

Weird case where the Inspect Tokens command shows the correct tokens: (See how the first is correct but the second is not)

Screen Shot 2021-10-08 at 4 58 17 PM

Screen Shot 2021-10-08 at 4 58 12 PM

However on run of testcase for [title]<path with spaces> it shows the incorrect tokens for the text:

{
    "c": "path",
    "t": "text.html.markdown meta.paragraph.markdown meta.tag.other.unrecognized.html.derivative entity.name.tag.html",
    "r": {
	"dark_plus": "entity.name.tag: #569CD6",
	"light_plus": "entity.name.tag: #800000",
	"dark_vs": "entity.name.tag: #569CD6",
	"light_vs": "entity.name.tag: #800000",
	"hc_black": "entity.name.tag: #569CD6"
    }
}

Not sure if it's a bug with VS Code or how I added the rule.

Related to #80

Correct in inspect scope but incorrect in generated testcase
@tanhakabir tanhakabir requested a review from mjbvz October 9, 2021 00:02
@tanhakabir tanhakabir changed the title Add rule for paths with spaces. Add rule for links with html tags that have spaces. Oct 9, 2021
@tanhakabir
Copy link
Contributor Author

Related to #66 as well

@tanhakabir
Copy link
Contributor Author

@alexdima do you have an idea of why there's a discrepancy between the Inspect tool and the textmate scopes identified on run?

@alexdima
Copy link
Member

@tanhakabir In the screenshot you use the text [title](<path with spaces>) yet in your comment you mention a test case of [title]<path with spaces>:

image

Maybe that would explain the difference you are seeing?

@tanhakabir
Copy link
Contributor Author

@alexdima you're right, my bad! That fixed the token scopes between the test results and the Inspect tool.

But I'm still having issues rendering correctly even though the tokens are correct.
image

@mjbvz do you think this is an issue in core at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants