Skip to content

Conversation

@aeschli
Copy link
Collaborator

@aeschli aeschli commented Nov 2, 2025

No description provided.

@aeschli aeschli enabled auto-merge (squash) November 2, 2025 22:41
@aeschli aeschli self-assigned this Nov 2, 2025
@aeschli aeschli merged commit d9d449b into main Nov 2, 2025
6 checks passed
@aeschli aeschli deleted the aeschli/zippy-falcon-568 branch November 2, 2025 22:44
@jeremyfiel
Copy link
Contributor

jeremyfiel commented Nov 20, 2025

this doesn't appear to work as intended. @aeschli

take the following example:

{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/user-profile.schema.json",
  "unevaluatedProperties": false,
  "type": "object",
  "required": ["name"],
  "properties": {
    "name": { "type": "string" }
  }
}

Failing Instance

# yaml-language-server: $schema=c:\users\fieljere\repos\api-specs\untitled-1.json

true

The error output gives a random message about user-profile. Is the intention to reference the schema $id?

[{
"resource": "Untitled-2",
"owner": "generated_diagnostic_collection_name#1",
"severity": 8,
"message": "Incorrect type. Expected "user-profile".",
"source": "yaml-schema: file:///c%3A/users/fieljere/repos/api-specs/untitled-1.json",
"startLineNumber": 3,
"startColumn": 1,
"endLineNumber": 3,
"endColumn": 5,
"origin": "extHost1"
}]

another example:

# yaml-language-server: $schema=c:\users\fieljere\repos\api-specs\untitled-1.json

{
  "jeremy": 1
}

No error output This should throw an error for unevaluatedProperties


Version: 1.106.2 (user setup)
Commit: 1e3c50d64110be466c0b4a45222e81d2c9352888
Date: 2025-11-19T16:56:50.023Z
Electron: 37.7.0
ElectronBuildId: 12781156
Chromium: 138.0.7204.251
Node.js: 22.20.0
V8: 13.8.258.32-electron.0
OS: Windows_NT x64 10.0.22631

@aeschli
Copy link
Collaborator Author

aeschli commented Nov 21, 2025

@jeremyfiel Please create an issue if you can reproduce that in pure JSON
YAML is an extension, I don't know if they have adopted already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants