Skip to content

Conversation

IBERMOLINA
Copy link

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 21, 2025 06:30
Copy link
Contributor

@IBERMOLINA please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a DevOps-focused setup to streamline local and containerized development, add CI/CD workflows, and document automation and run instructions.

  • Add setup/start scripts, Docker Compose files, and a Makefile for local/Docker dev flows.
  • Add CI and release GitHub Actions, pre-commit hooks, Dependabot, and CODEOWNERS.
  • Update documentation (README and automation requirements) and devcontainer configuration.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
scripts/start.sh Entry point to auto-run setup and start dev via Docker or local pnpm.
scripts/setup.sh First-time setup: tool checks, pnpm install, corepack enable, monorepo install/build.
scripts/protect-repos.sh Utility to apply repo privacy, security settings, and branch protections via GitHub API.
package.json Adds setup/start/dev/build scripts aligned with new tooling.
docs/automation/requirements.md Documents CI/release requirements and provides a release workflow skeleton.
docker-compose.yml Production-oriented web service Compose definition with healthcheck.
docker-compose.dev.yml Dev overrides for web service with bind mounts and dev command.
README.md Adds instructions for running apps, setup, and building via Docker.
Makefile Convenience targets for setup, start, dev, build, and clean.
LifeMtrics-buildsetup Adds submodule reference for the monorepo.
.pre-commit-config.yaml Adds standard pre-commit hooks.
.github/workflows/release.yml Release workflow to create GitHub Releases on tag or manual dispatch.
.github/workflows/ci.yml CI workflow with build/checks and pre-commit jobs.
.github/pull_request_template.md Adds PR template with checks and guidance.
.github/dependabot.yml Dependabot config for GitHub Actions and npm updates.
.github/CODEOWNERS Sets code ownership for key paths.
.gitattributes Removes two LFS path rules; keeps linguist settings.
.devcontainer/devcontainer.json Dev container config with Node 20 and Docker-in-Docker features.

"postCreateCommand": "./scripts/setup.sh",
"remoteUser": "vscode",
"mounts": [
"source=${localWorkspaceFolder}/.git,target=/workspaces/vscode-docs/.git,type=bind,consistency=cached"
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mount target path hardcodes /workspaces/vscode-docs/.git, which will break if the container workspace folder name differs (for example, in forks or renamed folders). Use the devcontainer variable for the container workspace path to make it robust, for example: "source=${localWorkspaceFolder}/.git,target=${containerWorkspaceFolder}/.git,type=bind,consistency=cached".

Suggested change
"source=${localWorkspaceFolder}/.git,target=/workspaces/vscode-docs/.git,type=bind,consistency=cached"
"source=${localWorkspaceFolder}/.git,target=${containerWorkspaceFolder}/.git,type=bind,consistency=cached"

Copilot uses AI. Check for mistakes.

echo "🔍 Checking for required tools..."

if ! command -v node &> /dev/null; then
echo "❌ Node.js is not installed. Please install Node.js 20+"
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enforces Node.js 20+, but the CI and release workflows currently use Node 18.x, which creates an avoidable environment mismatch. Align on a single Node version across setup, devcontainer, CI, and release (recommend upgrading workflows and docs to Node 20.x to match setup/devcontainer, or relax this requirement to 18.x).

Suggested change
echo "❌ Node.js is not installed. Please install Node.js 20+"
echo "❌ Node.js is not installed. Please install Node.js 18+"

Copilot uses AI. Check for mistakes.

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18.x
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node is pinned to 18.x here while setup.sh and the devcontainer specify Node 20. Standardize the Node version (suggest 20.x) to avoid CI-only discrepancies and hard-to-reproduce issues.

Suggested change
node-version: 18.x
node-version: 20.x

Copilot uses AI. Check for mistakes.

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18.x
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node is pinned to 18.x here, which is inconsistent with Node 20 in setup/devcontainer. Align to the same Node major version across environments (recommend 20.x).

Suggested change
node-version: 18.x
node-version: 20.x

Copilot uses AI. Check for mistakes.

Comment on lines +16 to +18
* Node: 18.x.
* Permissions: `contents: read`.
* Concurrency: One CI run per ref, cancel in-progress.
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document specifies Node 18.x, but the devcontainer and setup script target Node 20. Update this to the chosen standard (suggest 20.x) to keep the requirements accurate.

Copilot uses AI. Check for mistakes.

workflow_dispatch:
inputs:
version:
description: Release version (e.g., v1.2.3)
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the Latin abbreviation "e.g." with "for example" to follow the docs style guide. For example: description: Release version (for example, v1.2.3).

Suggested change
description: Release version (e.g., v1.2.3)
description: Release version (for example, v1.2.3)

Copilot uses AI. Check for mistakes.


Publishing merged pull requests is not automatic and is initiated manually after changes have been reviewed on an internal staging server. There is no specific time guarantee for when PR updates will be available on https://code.visualstudio.com but the intent is that they will usually be live within 24 hours.

## Running the Apps
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sentence-style capitalization for headings per the docs style guide. Change to "## Running the apps".

Suggested change
## Running the Apps
## Running the apps

Copilot uses AI. Check for mistakes.

Comment on lines +96 to +101
```bash
npm run setup
# or
make setup
```

Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because LifeMtrics-buildsetup is a submodule, include a step to initialize submodules before setup, for example: git submodule update --init --recursive. This prevents setup.sh from failing when the submodule directory is missing.

Suggested change
```bash
npm run setup
# or
make setup
```
1. **Initialize submodules (required for first-time setup):**
```bash
git submodule update --init --recursive
  1. Run setup:

    npm run setup
    # or
    make setup

Copilot uses AI. Check for mistakes.

local path="$1"; shift
curl -sS -X "$method" \
-H "Authorization: Bearer $GITHUB_TOKEN" \
-H "Accept: application/vnd.github+json" \
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests with JSON bodies are missing a Content-Type header, which can lead to API misinterpretation. Add -H "Content-Type: application/json" to the api() function for PATCH/PUT calls that send JSON.

Suggested change
-H "Accept: application/vnd.github+json" \
-H "Accept: application/vnd.github+json" \
-H "Content-Type: application/json" \

Copilot uses AI. Check for mistakes.


if ! command -v jq >/dev/null 2>&1; then
echo "jq is required (apt-get install -y jq)" >&2; exit 1
fi
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script also depends on curl but does not check for it. Add a curl presence check similar to jq to fail fast with a clear message.

Suggested change
fi
fi
if ! command -v curl >/dev/null 2>&1; then
echo "curl is required (apt-get install -y curl)" >&2; exit 1
fi

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant