Skip to content

Locked the double quote in path.with.spaces. #13598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025
Merged

Locked the double quote in path.with.spaces. #13598

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aedd81d
Locked the double quote in path.with.spaces.
sean-mcmanus May 9, 2025
9adc612
Alternative fix.
sean-mcmanus May 12, 2025
f726a12
Fix locked comment.
sean-mcmanus May 12, 2025
5e8b21d
Merge branch 'main' into seanmcm/lockPathWithSpaces
sean-mcmanus May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Extension/src/LanguageServer/configurations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,8 @@ export class CppProperties {

const compilerPathErrors: string[] = [];
if (compilerPathMayNeedQuotes && !pathExists) {
compilerPathErrors.push(localize("path.with.spaces", 'Compiler path with spaces could not be found. If this was intended to include compiler arguments, surround the compiler path with double quotes (").'));
compilerPathErrors.push(localize({ key: "path.with.spaces", comment: ["{Locked=\"{0}\"} The {0} is a double quote character \", and should be located next to the translation for \"double quotes\"."] },
"Compiler path with spaces could not be found. If this was intended to include compiler arguments, surround the compiler path with double quotes ({0}).", '"'));
telemetry.CompilerPathMissingQuotes = 1;
}

Expand Down