Skip to content

Fix SIG-?? matching the filter regex. #13493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025
+3 −6
Merged

Fix SIG-?? matching the filter regex. #13493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,9 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr
signalType = lines[crashStackStartLine] + "\n";
} else {
// The signal type may fail to be written.
signalType = "SIG-??\n"; // Intentionally different from SIG-? from cpptools.
// Intentionally different from SIGUNKNOWN from cpptools,
// and not SIG-? to avoid matching the regex in containsFilteredTelemetryData.
signalType = "SIGMISSING\n";
}
data = telemetryHeader + signalType;
let crashCallStack: string = "";
Expand Down Expand Up @@ -1329,11 +1331,6 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr

data += crashCallStack;

// TODO: Remove this in 1.25.1 after it's confirmed that it's not happening.
if (containsFilteredTelemetryData(data)) {
data = "unexpected call stack\n";
}

logCppCrashTelemetry(data, addressData, crashLog);

await util.deleteFile(path.resolve(crashDirectory, crashFile)).catch(logAndReturn.undefined);
Expand Down