Skip to content

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Aug 23, 2024

Fixes: #11700

ex:

Modified Settings:
{
    "C_Cpp.default.compilerPath": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Preview\\VC\\Tools\\Llvm\\x64\\bin\\clang++.exe",
    "C_Cpp.loggingLevel": "Debug"
}

@sean-mcmanus
Copy link
Contributor

I don't see files.associations logged -- is that intentional? I'm guessing it is.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 23, 2024

Also, I don't see "C_Cpp.files.exclude" logged -- that seems unintentional since it can be important for diagnostics since it'll cause symbols to not be found at those locations. Umm...not sure if files.exclude should be logged too then?

Same with C_Cpp.codeAnalysis.exclude.

Maybe you could file a follow up issue for those?

@bobbrow
Copy link
Member Author

bobbrow commented Aug 23, 2024

I'll take a look at the complex types @sean-mcmanus. I pushed this without testing all of the different types and encountered a bug in the settings tracker around integer vs. number too. Moving this PR to draft for now...

@bobbrow bobbrow marked this pull request as draft August 23, 2024 23:55
@bobbrow bobbrow added this to the On Deck milestone Aug 23, 2024
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 23, 2024

@bobbrow Yeah, for example, C_Cpp.clang_format_style:
image

@bobbrow bobbrow marked this pull request as ready for review August 26, 2024 18:00
@bobbrow
Copy link
Member Author

bobbrow commented Aug 26, 2024

@sean-mcmanus this should address your previous comments now. I did not log editor settings, only those in the C_Cpp block. If I get time later this week I might add a few of the other settings that our extension tracks.

@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.22.0 Aug 26, 2024
@bobbrow bobbrow merged commit e5ce40b into main Aug 26, 2024
6 checks passed
@bobbrow bobbrow deleted the bobbrow/logSettings branch August 26, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add setting values to Log Diagnostics output
2 participants