Auto indentation rules

[csholmq]

With the new editor.autoIndent option, language extension authors can provide indentation rules.

As this is the main extension for C/C++ language development, perhaps a few rules could be included?

https://code.visualstudio.com/updates/v1_14#_auto-indent-on-type-move-lines-and-paste

[sean-mcmanus]

Thanks for letting us know about this. Another user also recently requested autoIndent for one-line if/while/etc. statements that don't start with {.

[csholmq]

You're very welcome! So many new features coming out it's hard to keep track.

With the built in support in VSCode, I'm hoping it would be a minor task for you guys to write up some rules. You ciuld probably knick some from another extension, e.g Java.

[sean-mcmanus]

One user is getting the behavior you want, but we don't have a repro: #887 . In the Allman style, the { goes on a new line so the indentation is not desired on Enter, unless typing { can undo the indent.

[csholmq]

Yes. Well basically don't indent if a curly brace is involved.

[rebornix]

@sean-mcmanus for your information, VSCode indentation rules follow TextMate so to make this happen, you can

• Follow TextMate documentation https://manual.macromates.com/en/appendix
• Build on top of existing community indentation rules (Atom) and make enhancements.

Let me know if you run into any problem while adopting this feature.

[shunyaoshih]

I need an autoIndent for one-line if/while/for, too. Look forward to this feature!
Maybe VS Code could provide developers with "indentNextLinePattern" which is included in TextMate. With this indentation rule, I think it will be much easier to implement this feature.

[antcodd]

The reindent lines feature seems to seriously mangle block comments. The indentation rules should probably preserve the indent withing block comments, doubly so if the lines are preceeded by *?

e.g.

/*
 * Foo
 */

becomes

/*
* Foo
*/

[sean-mcmanus]

@antcodd What reindent lines feature are you talking about? Does it repro without the cpptools extension installed? Are you doing a format?

[antcodd]

@sean-mcmanus The Reindent Lines command introduces in VSCode 1.9, which I believe uses the same language indent rules as the original link in this issue. This is distinct from the Format Document feature, although I think at one point one was falling back to the other (not sure which way around). See also the discussion in microsoft/vscode#28658 and microsoft/vscode#19847

It looks like there is a already a bug for this comment whitespace issue, at least for TypeScript: microsoft/vscode#19142.
Even more problematically it also reformats single line if blocks, which may be the same issue mentioned there by @rebornix.

if (foo)
    dosomething();

to

if (foo)
dosomething()

To be honest I'm not quite sure where this discussion fits, is there an issue tracker for language-c in VSCode? I suspect the Atom folks will be reluctant to work around issues in VSCode.

Basically, I got burned by a number of issues with Reindent Lines (not operating on the selection only, adding trimmed whitespace and messing with comments/if) combined with VSCode not showing whitespace changes in the git gutter. I'm having to carefully revert some unstaged changes because of this.

[sean-mcmanus]

@antcodd The atom/language-c issues page is https://github.com/atom/language-c/issues , but I'm not sure if this is an atom/language-c issue.