Fix @actionSeparator decorator to only accept Operation, Interface, and Namespace targets #8609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
@actionSeparator
decorator target validation to narrow allowed targets fromModel | ModelProperty | Operation
toOperation | Interface | Namespace
.Problem
The
@actionSeparator
decorator was incorrectly defined to accept Model and ModelProperty targets, but these targets don't work properly with the decorator's functionality. When users tried to apply@actionSeparator
to interfaces (a logical use case), they would get confusing errors:Additionally, applying the decorator to models or model properties would be accepted but wouldn't function correctly.
Solution
Updated the decorator definition to only accept targets where it actually works:
Before:
After:
Changes Made
packages/rest/src/rest.ts
packages/rest/lib/rest-decorators.tsp
packages/rest/generated-defs/TypeSpec.Rest.ts
Validation
The fix now correctly:
@actionSeparator
on Operations, Interfaces, and Namespaces@actionSeparator
on Models and ModelProperties with clear error messages/
,:
,/:
)All existing tests continue to pass (54/54), ensuring no regressions were introduced.
Resolves the original issue where users couldn't apply
@actionSeparator
to interfaces, and prevents future confusion by only allowing the decorator on targets where it actually functions correctly.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build
node /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/astro.js build
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.