http-client-java, continuationToken can be used in azurev2 #8601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
| let continuationTokenResponseProperty: Property[] | undefined; | ||
| let continuationTokenResponseHeader: HttpHeader | undefined; | ||
| if (!this.isBranded()) { | ||
| if (!this.isAzureV1()) { |
There was a problem hiding this comment.
azurev2 can have same generated code, as unbranded
weidongxu-microsoft
requested review from
srnagar,
anuchandy,
haolingdong-msft and
XiaofeiCao
as code owners
| const schemaName = groupToRequestConditions ? "RequestConditions" : "MatchConditions"; | ||
| let schemaName = groupToRequestConditions ? "RequestConditions" : "MatchConditions"; | ||
| if (!this.isBranded()) { | ||
| schemaName = "Http" + schemaName; |
There was a problem hiding this comment.
they have different name in clientcore...
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/HttpRequestConditions.java
There was a problem hiding this comment.
Pull Request Overview
Enables continuation token support for Azure V2 client generation while improving request conditions naming for unbranded clients. The PR addresses limitations in the HTTP client Java emitter for paginated APIs.
- Enables continuation token functionality for Azure V2 clients (not just unbranded)
- Adds validation to warn when nested page items are used with Azure V1
- Fixes request conditions schema naming for unbranded clients by prefixing with "Http"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/http-client-java/emitter/src/lib.ts | Adds new diagnostic message for nested page items unsupported in Azure V1 |
| packages/http-client-java/emitter/src/code-model-builder.ts | Updates logic to support continuation tokens in Azure V2, adds validation for nested page items, and fixes schema naming for unbranded clients |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case in storage-blob
https://github.com/Azure/azure-rest-api-specs/blob/82057ab083fe06e1e1584e8c846af87cf8237a58/specification/storage/Microsoft.BlobStorage/models.tsp#L222-L231
However there seems to be other bugs on azurev2, when running on my local.
This fixes some issue, but not all of them, in azurev2.