Fix vscode e2e test when making a release pr #8459
Conversation
microsoft-github-policy-service
bot
added
the
ide
|
All changed packages have been documented.
|
v-zhocai
force-pushed
the
fix_vscode_e2e_test
branch
from
cebd6c2 to
36293c9
Compare
v-zhocai
force-pushed
the
fix_vscode_e2e_test
branch
from
bfee85c to
283f091
Compare
v-zhocai
force-pushed
the
fix_vscode_e2e_test
branch
from
283f091 to
76e3227
Compare
v-zhocai
requested review from
AlitzelMendez,
RodgeFu,
bterlson,
chrisradek,
lirenhe,
markcowl,
timotheeguerin and
witemple-msft
as code owners
There was a problem hiding this comment.
revert this underlying issue was fixed
There was a problem hiding this comment.
We have re-verified and found that this issue has not been fixed. Could you please help double-check it?
There was a problem hiding this comment.
it is fixed in main but not published, which would work if we installed the local version as the other comment suggest
There was a problem hiding this comment.
Sorry. We are now using local version packages in main and the reverted openapi.yaml file, but the import test is still failing. Did we miss something during our testing process? Could you please help take another look at this issue?
There was a problem hiding this comment.
yeah you are right, my bad, seems I only fixed the server description issue but not on server params.
Should be fixed here #8764
If you want to change the file I would also just go and make this teh most basic openapi3 file with nothing in it as the goal of this test is not really to test the converter but just the integration.
| let shouldSkip = false; | ||
|
|
||
| shouldSkip = tryInstallAndHandle("@typespec/http") || shouldSkip; | ||
| shouldSkip = tryInstallAndHandle("@typespec/http-client-csharp") || shouldSkip; |
There was a problem hiding this comment.
could we maybe just use http-client-js as its already part of the workspace instead of csharp which is also extermly slow and require to keep inline with whatever other dependency they have
There was a problem hiding this comment.
OK, we have now switched to using http-client-js for testing.
| */ | ||
| export function tryInstallAndHandle(pkg: string): boolean { | ||
| try { | ||
| execSync(`pnpm install ${pkg}`, { stdio: "pipe" }); |
There was a problem hiding this comment.
where is this being run? I think the source of most of this is that we should not also be patching anything on the vscode package.
Can this be done in a temp folder and link the lcoal version of every package(they are all there) to not depend on any extra remote issues
There was a problem hiding this comment.
see the e2e-tests.js for the whole cli that does this with currrent
There was a problem hiding this comment.
The old method tryInstallAndHandle is being used before tests and has been removed. According to the e2e-test.js file you provided as a reference, we've implemented tests to use dependencies from the local repository instead of downloading them from a remote repository, and have also moved the tests to a temp folder beforehand.
2 participants
Fix issues#8402
Changes:
http-client-csharptohttp-client-js.