Fix decorating the language service #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript plugins using this library were incompatible with Volar. This is fixed by patching the language service instead of a Proxy object.
|
@mjbvz is this repo still active / maintained / receiving new bugfixes? Or should these changes be redirected elsewhere? (just looking at the last commit being 2 years ago) This issue is affecting multiple VS Code extensions in the ecosystem:
(according to styled-components/vscode-styled-components#448, maybe also the Vue, Astro and Ember extensions) |
|
“Affecting” in the sense that all TypeScript plugins interact with each other. Of those plugins only Styled components actually uses this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript plugins using this library were incompatible with Volar. This is fixed by patching the language service instead of a Proxy object.
I’m not entirely sure why this works, but it does. Hence I’m not sure how to test it. Existing tests pass though.
This is related to mdx-js/mdx-analyzer#451. I confirmed that this change solves that problem by applying them in
node_modules.