Port PR 62923: Fix crash in abstract property checking for unnamed class expressions #2423
+75
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports TypeScript PR #62923 which fixes a crash when checking abstract properties in unnamed class expressions. The compiler previously crashed with
Cannot read properties of undefined (reading 'kind')when encountering abstract properties in class expressions without names.Changes
internal/checker/checker.go: Modified
checkPropertyAccessibilityAtLocationto check parent symbol flags directly instead of callingGetClassLikeDeclarationOfSymbol, which returns nil for unnamed class expressions. Now usessymbolToString(parentSymbol)for error messages, handling both named and unnamed classes.testdata/tests/cases/compiler/errorInUnnamedClassExpression.ts: Added test case covering the crash scenario.
Example
Previously crashed:
Now produces proper error:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.