Update submodule to rev without ES5 transforms, unicodeES5Identifier #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the compiler submodule baselines to remove legacy ES5 transforms and unicodeES5Identifier support, aligning them with the modern ES6+ syntax used in the main repo.
- Replaced generated helper wrappers (
__extends,__generator, etc.) with nativeclass,async/await, andfunction*syntax. - Swapped all
vardeclarations forlet/const, and classic function expressions for arrow functions and method shorthand. - Updated binding patterns, shorthand properties, and collection literals in test baselines to reflect ES6+ patterns.
andrewbranch
approved these changes
Jun 18, 2025
DanielRosenwasser
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to stop supporting ES5 transforms. They haven't been added to this repo, but are still present in our submodule, which then creates loads of diffs (mainly, let/const/class). I've now updated the porting branch / submodule to no longer contain ES5 transforms nor unicodeES5Identifier, more closely matching this repo.
This removes >14k baselines, >300k lines of diffs.
This PR does not change anything about deprecations, libs, etc. It's just targeted at fixing emit diffs.