panic handling request textDocument/references Unhandled case in Node.Text: *ast.BindingPattern

[jakebailey]

@jakebailey the IDE is back to the state where it does this every couple of minutes.
Please let me know if there's any additional info that would be useful.

Is it possible to suppress this error in the meantime?

[10:07:45.515] Updated watches in 53.166µs
panic handling request textDocument/references Unhandled case in Node.Text: *ast.BindingPattern goroutine 701923 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).recover(0x14000000f00, 0x140c0c88ff0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:568 +0x44
panic({0x10099c220?, 0x14056ca2940?})
	runtime/panic.go:783 +0x120
github.com/microsoft/typescript-go/internal/ast.(*Node).Text(0x14001bbe908?)
	github.com/microsoft/typescript-go/internal/ast/ast.go:338 +0x418
github.com/microsoft/typescript-go/internal/checker.(*Checker).getSymbolAtLocation(0x140636c8608, 0x1400d083de8, 0x1)
	github.com/microsoft/typescript-go/internal/checker/checker.go:30405 +0xefc
github.com/microsoft/typescript-go/internal/checker.(*Checker).GetSymbolAtLocation(...)
	github.com/microsoft/typescript-go/internal/checker/checker.go:30345
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesAtLocation(0x140ab5a1a40, 0x14014c03e29?, 0x5?, 0x1400062fc00, 0x1)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1597 +0x80
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesInContainer(0x140ab5a1a40, 0x14001bbe908, 0x14001bbe908, 0x1400062fc00, 0x1)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1554 +0x94
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesInSourceFile(...)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1542
github.com/microsoft/typescript-go/internal/ls.(*refState).searchForName(0x140ab5a1a40, 0x14001bbe908, 0x1400062fc00)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:2016 +0x68
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesInContainerOrFiles(0x140ab5a1a40, 0x14014d88f28?, 0x1400062fc00)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1535 +0x5c
github.com/microsoft/typescript-go/internal/ls.getReferencedSymbolsForSymbol(0x140357a9868, 0x14014d88f28, {0x1407794c000, 0x1b8e, 0x1c00}, 0x1406e90bb28, 0x140636c8608, {0x0, 0x0, 0x2, ...})
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1219 +0x368
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).getReferencedSymbolsForNode(0x1406b2a99e0, {0x100bbc5c0, 0x140e0bb3c70}, 0x9e4d, 0x14014d88f28, 0x140bf4d7860, {0x1407794c000, 0x1b8e, 0x1c00}, {0x0, ...}, ...)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:687 +0x624
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideReferences(0x1406b2a99e0, {0x100bbc5c0, 0x140e0bb3c70}, 0x140c0c88fc0)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:417 +0xa8
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleReferences(0x140002a6a20?, {0x100bbc5c0?, 0x140e0bb3c70?}, 0x14042bc6690?, 0x65?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:828 +0x2c
github.com/microsoft/typescript-go/internal/lsp.init.func1.registerLanguageServiceDocumentRequestHandler[...].17({0x100bbc5c0, 0x140e0bb3c70}, 0x140c0c88ff0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:554 +0xe0
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0x14000000f00, {0x100bbc5c0, 0x140e0bb3c70}, 0x140c0c88ff0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:449 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:354 +0x34
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 10
	github.com/microsoft/typescript-go/internal/lsp/server.go:374 +0x79c

[Error - 10:07:45 AM] Request textDocument/references failed.
  Message: InternalError: panic handling request textDocument/references: Unhandled case in Node.Text: *ast.BindingPattern
  Code: -32603 
panic handling request textDocument/references Unhandled case in Node.Text: *ast.BindingPattern goroutine 697916 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).recover(0x14000000f00, 0x14010d57290)
	github.com/microsoft/typescript-go/internal/lsp/server.go:568 +0x44
panic({0x10099c220?, 0x14058eeb410?})
	runtime/panic.go:783 +0x120
github.com/microsoft/typescript-go/internal/ast.(*Node).Text(0x14001bbe908?)
	github.com/microsoft/typescript-go/internal/ast/ast.go:338 +0x418
github.com/microsoft/typescript-go/internal/checker.(*Checker).getSymbolAtLocation(0x140636c8608, 0x1400d083de8, 0x1)
	github.com/microsoft/typescript-go/internal/checker/checker.go:30405 +0xefc
github.com/microsoft/typescript-go/internal/checker.(*Checker).GetSymbolAtLocation(...)
	github.com/microsoft/typescript-go/internal/checker/checker.go:30345
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesAtLocation(0x140b07cf040, 0x14014c03e29?, 0x5?, 0x14000cd47e0, 0x1)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1597 +0x80
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesInContainer(0x140b07cf040, 0x14001bbe908, 0x14001bbe908, 0x14000cd47e0, 0x1)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1554 +0x94
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesInSourceFile(...)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1542
github.com/microsoft/typescript-go/internal/ls.(*refState).searchForName(0x140b07cf040, 0x14001bbe908, 0x14000cd47e0)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:2016 +0x68
github.com/microsoft/typescript-go/internal/ls.(*refState).getReferencesInContainerOrFiles(0x140b07cf040, 0x14014d88f28?, 0x14000cd47e0)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1535 +0x5c
github.com/microsoft/typescript-go/internal/ls.getReferencedSymbolsForSymbol(0x140357a9868, 0x14014d88f28, {0x1407794c000, 0x1b8e, 0x1c00}, 0x1406d576db8, 0x140636c8608, {0x0, 0x0, 0x2, ...})
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:1219 +0x368
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).getReferencedSymbolsForNode(0x140786ac450, {0x100bbc5c0, 0x140254bc550}, 0x9e4d, 0x14014d88f28, 0x140bf4d7860, {0x1407794c000, 0x1b8e, 0x1c00}, {0x0, ...}, ...)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:687 +0x624
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideReferences(0x140786ac450, {0x100bbc5c0, 0x140254bc550}, 0x14010d57260)
	github.com/microsoft/typescript-go/internal/ls/findallreferences.go:417 +0xa8
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleReferences(0x140002a6a20?, {0x100bbc5c0?, 0x140254bc550?}, 0x14042a6ef50?, 0x65?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:828 +0x2c
github.com/microsoft/typescript-go/internal/lsp.init.func1.registerLanguageServiceDocumentRequestHandler[...].17({0x100bbc5c0, 0x140254bc550}, 0x14010d57290)
	github.com/microsoft/typescript-go/internal/lsp/server.go:554 +0xe0
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0x14000000f00, {0x100bbc5c0, 0x140254bc550}, 0x14010d57290)
	github.com/microsoft/typescript-go/internal/lsp/server.go:449 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:354 +0x34
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 10
	github.com/microsoft/typescript-go/internal/lsp/server.go:374 +0x79c

[Error - 10:07:45 AM] Request textDocument/references failed.

Originally posted by @richburdon in #1867

[jakebailey]

@richburdon do you know where you are requesting find-all-refs when this happens?

[richburdon]

@jakebailey I can't deterministically make it happen, but it happens for me and my colleagues every couple of minutes when actively editing code. Something is happening in the background since I can't correlate it to a specific action; certainly no menu-drive activity. Generally, just moving through the codebase after making some edits. This is in a fairly large monorepo with about 100 packages.

Here's another one with a different error message.

anic handling request textDocument/definition bad line number. Line: 92, lineMap length: 84 goroutine 5267388 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).recover(0x14000000f00, 0x140fb7c4de0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:568 +0x44
panic({0x1033ec220?, 0x141054e17e0?})
	runtime/panic.go:783 +0x120
github.com/microsoft/typescript-go/internal/ls.(*Converters).LineAndCharacterToPosition(0x14105582888, {0x10360ac90, 0x140ec466608}, {0x8?, 0x0?})
	github.com/microsoft/typescript-go/internal/ls/converters.go:143 +0x29c
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideDefinition(0x14109f92ea0, {0x10360c5c0, 0x141043a9bd0}, {0x140fb7befc0?, 0x1404462d638?}, {0x2c73608?, 0x1?})
	github.com/microsoft/typescript-go/internal/ls/definition.go:17 +0x80
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleDefinition(0x14000324a20?, {0x10360c5c0?, 0x141043a9bd0?}, 0x140fb7befc0?, 0x5f?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:819 +0x38
github.com/microsoft/typescript-go/internal/lsp.init.func1.registerLanguageServiceDocumentRequestHandler[...].14({0x10360c5c0, 0x141043a9bd0}, 0x140fb7c4de0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:554 +0xf0
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0x14000000f00, {0x10360c5c0, 0x141043a9bd0}, 0x140fb7c4de0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:449 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:354 +0x34
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 20
	github.com/microsoft/typescript-go/internal/lsp/server.go:374 +0x79c

[jakebailey]

Yes, that's totally different. #1673

[ahejlsberg]

Reading over (*Checker).GetSymbolAtLocation and its uses of (*Node).Text(), I think the issue is that we're not checking for binding patterns before obtaining the names of parameters in when matching JSDoc @param tags. Here's a short repro:

/**
 * @param count de Monet
 */
function foo({ name, message }: Error, count: number) {}

Hovering around in this example causes panics. It's a simple fix. I'll put up a PR.

[ahejlsberg]

Ah, I missed that Copilot already figured it out (with some heavy coaching 😄).

[richburdon]

@ahejlsberg I'm still seeing this error in 0.20251103.1 installed today.

Pls let me know if I can help with any other info.

We get these panics every couple of minutes and it would be great to be able to silence them.

[16:12:40.237] Updated watches in 74µs
panic handling request textDocument/definition bad line number. Line: 1085, lineMap length: 221 goroutine 643006 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).recover(0x140001fcdc0, 0x140b166e000)
	github.com/microsoft/typescript-go/internal/lsp/server.go:570 +0x44
panic({0x1052483c0?, 0x1404bfd8790?})
	runtime/panic.go:783 +0x120
github.com/microsoft/typescript-go/internal/ls/lsconv.(*Converters).LineAndCharacterToPosition(0x1406673d488, {0x1054670f0, 0x14029018c08}, {0xc?, 0x0?})
	github.com/microsoft/typescript-go/internal/ls/lsconv/converters.go:143 +0x29c
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideDefinition(0x140ab50f590, {0x105468a20, 0x140964c2550}, {0x14092b720e0?, 0x14035d3fe48?}, {0x4fbc628?, 0x1?}, 0x1)
	github.com/microsoft/typescript-go/internal/ls/definition.go:23 +0x84
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleDefinition(0x140002a8a20?, {0x105468a20?, 0x140964c2550?}, 0x14092b720e0?, 0x6b?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:825 +0x78
github.com/microsoft/typescript-go/internal/lsp.init.func1.registerLanguageServiceDocumentRequestHandler[...].14({0x105468a20, 0x140964c2550}, 0x140b166e000)
	github.com/microsoft/typescript-go/internal/lsp/server.go:556 +0xf0
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0x140001fcdc0, {0x105468a20, 0x140964c2550}, 0x140b166e000)
	github.com/microsoft/typescript-go/internal/lsp/server.go:451 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:356 +0x34
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 23
	github.com/microsoft/typescript-go/internal/lsp/server.go:376 +0x79c

[Error - 4:12:40 PM] Request textDocument/definition failed.
  Message: InternalError: panic handling request textDocument/definition: bad line number. Line: 1085, lineMap length: 221
  Code: -32603 
[16:12:40.784] Processed 1 file changes in 33.875µs

[jakebailey]

As I said above, that is a different panic, tracked in #1673.