Truncate issue comments #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like better this solution instead of doing chunks. I feel like we still want to truncate the comments in case they are too long because most likely they are going to be annoying to handle, maybe even to a more manageable size and not necessarily the max amount. We can define the size, if necessary, after some weeks of dealing with this. |
armanio123
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://typescript.visualstudio.com/TypeScript/_build/results?buildId=162915&view=logs&j=15ac8a4d-b341-5815-5352-14d7ae9c5a86&t=b4a5e2cd-8727-5d20-e3d3-86822d3c46a6 failed because it tried to send a comment that was too long.
Truncate these with a message instead of failing.
We could chunk them like the other thing, maybe.