This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Enabled no-non-null-assertion internally #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes @IllusionMH's changes to `exportNameRule.ts` from #666. This shouldn't be merged in until that PR is. Continues #491.
IllusionMH
approved these changes
Dec 11, 2018
| protected visitImportDeclaration(node: ts.ImportDeclaration): void { | ||
| if (node.importClause!.name !== undefined) { | ||
| const name: string = node.importClause!.name!.text; | ||
| if (node.importClause !== undefined && node.importClause.name !== undefined) { |
There was a problem hiding this comment.
This change should fix exception mentioned in #667 (comment), however not sure if helps with original exception #667.
May be worth to add test for import 'some-module'; after #665 will be merged?
| } | ||
|
|
||
| protected visitPropertyAssignment(node: ts.PropertyAssignment): void { | ||
| super.visitPropertyAssignment(node); |
apawast
pushed a commit
to lupine86/tslint-microsoft-contrib
that referenced
this pull request
Feb 26, 2019
Includes @IllusionMH's changes to `exportNameRule.ts` from microsoft#666. This shouldn't be merged in until that PR is. Continues microsoft#491.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes @IllusionMH's changes to✔exportNameRule.tsfrom #666. This shouldn't be merged in until that PR is.Continues #491.