-
Notifications
You must be signed in to change notification settings - Fork 15
feature: grpc: servicing operations #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements initial support for gRPC servicing operations in Trident, including install, update, and stream image functionality with full, stage, and finalize variants.
Key changes:
- Added gRPC service implementations for install, update, and stream_image operations
- Introduced
AgentConfigmodule for managing agent configuration - Enhanced error handling with new
full_bodyfield inTridentErrorfor better debugging - Added support for raw string Host Configuration sources
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/harpoon.proto | Formatting cleanup and API changes: added full_body to TridentError, updated ValidateHostConfigurationResponse fields |
| crates/trident_api/src/error.rs | Added conversion from TridentError to HarpoonTridentError, populated new full_body field with debug info |
| crates/trident_api/src/config/local.rs | Added RawString variant to HostConfigurationSource and From impl for Operation to Operations |
| crates/trident/src/validation.rs | Made parse_host_config accept optional path, added validate_host_config_string function |
| crates/trident/src/server/tridentserver/servicingmgr.rs | Added panic catching with UnwindSafe trait bound for servicing operations |
| crates/trident/src/server/tridentserver/mod.rs | Added AgentConfig, Logstream, and TraceStream dependencies, clearing streams after servicing |
| crates/trident/src/server/tridentserver/harpoon_impl.rs | Implemented install, update, stream_image, and validate_host_configuration gRPC endpoints |
| crates/trident/src/server/mod.rs | Integrated AgentConfig loading and passed logstream/tracestream to server initialization |
| crates/trident/src/main.rs | Moved AgentConfig to separate module, updated references |
| crates/trident/src/logging/tracestream.rs | Made TraceStream cloneable, added clear_server method |
| crates/trident/src/logging/logstream.rs | Made Logstream cloneable, added clear_server method |
| crates/trident/src/lib.rs | Added support for loading Host Configuration from RawString source |
| crates/trident/src/agentconfig.rs | New module for managing agent configuration with datastore path handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
🔍 Description
Initial support for:
Depends on: