Skip to content

Conversation

@frhuelsz
Copy link
Contributor

@frhuelsz frhuelsz commented Jan 6, 2026

🔍 Description

Initial support for:

  • install (full/stage/finalize)
  • update (full/stage/finalize)
  • stream image

Depends on:

@frhuelsz frhuelsz requested a review from a team as a code owner January 6, 2026 00:37
Copilot AI review requested due to automatic review settings January 6, 2026 00:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements initial support for gRPC servicing operations in Trident, including install, update, and stream image functionality with full, stage, and finalize variants.

Key changes:

  • Added gRPC service implementations for install, update, and stream_image operations
  • Introduced AgentConfig module for managing agent configuration
  • Enhanced error handling with new full_body field in TridentError for better debugging
  • Added support for raw string Host Configuration sources

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
proto/harpoon.proto Formatting cleanup and API changes: added full_body to TridentError, updated ValidateHostConfigurationResponse fields
crates/trident_api/src/error.rs Added conversion from TridentError to HarpoonTridentError, populated new full_body field with debug info
crates/trident_api/src/config/local.rs Added RawString variant to HostConfigurationSource and From impl for Operation to Operations
crates/trident/src/validation.rs Made parse_host_config accept optional path, added validate_host_config_string function
crates/trident/src/server/tridentserver/servicingmgr.rs Added panic catching with UnwindSafe trait bound for servicing operations
crates/trident/src/server/tridentserver/mod.rs Added AgentConfig, Logstream, and TraceStream dependencies, clearing streams after servicing
crates/trident/src/server/tridentserver/harpoon_impl.rs Implemented install, update, stream_image, and validate_host_configuration gRPC endpoints
crates/trident/src/server/mod.rs Integrated AgentConfig loading and passed logstream/tracestream to server initialization
crates/trident/src/main.rs Moved AgentConfig to separate module, updated references
crates/trident/src/logging/tracestream.rs Made TraceStream cloneable, added clear_server method
crates/trident/src/logging/logstream.rs Made Logstream cloneable, added clear_server method
crates/trident/src/lib.rs Added support for loading Host Configuration from RawString source
crates/trident/src/agentconfig.rs New module for managing agent configuration with datastore path handling

Copilot AI review requested due to automatic review settings January 6, 2026 20:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings January 6, 2026 20:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings January 7, 2026 08:04
@frhuelsz frhuelsz moved this from Backlog to In review in Trident gRPC API Jan 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

@frhuelsz
Copy link
Contributor Author

frhuelsz commented Jan 8, 2026

/AzurePipelines run [GITHUB]-trident-pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@frhuelsz frhuelsz self-assigned this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants