infra: Add VM serial monitoring to storm-e2e tests #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds VM serial console monitoring functionality to the storm-e2e testing framework. The implementation connects to the libvirt console in the background during test execution to capture and analyze serial output, providing enhanced debugging capabilities through artifact logging. The changes depend on the Storm framework v0.4.0-alpha1 release.
Key changes:
- Implements live VM serial console monitoring that captures output to test artifacts
- Adds libvirt connection management and serial log path resolution
- Updates test execution to include serial monitoring with timeout handling
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/storm/utils/io/notify_writer.go | New writer wrapper to track when first data is written to a stream |
| tools/storm/e2e/scenario/trident.go | Updated scenario structure with VM timeout parameter and conditional test registration |
| tools/storm/e2e/scenario/setup.go | Added VM host info interfaces and libvirt connection handling with cleanup |
| tools/storm/e2e/scenario/params.go | Added helper methods to check hardware type (IsVM/IsBM) |
| tools/storm/e2e/scenario/monitoring.go | Core serial monitoring implementation with login prompt detection and console streaming |
| tools/storm/e2e/scenario/install.go | Integrated serial monitor spawning with netlaunch execution and timeout handling |
| tools/pkg/virtdeploy/vm.go | Updated serial log filename format for consistency |
| tools/pkg/virtdeploy/status.go | Added domain definition and libvirt domain fields to VM status |
| tools/pkg/virtdeploy/resources.go | Store full domain XML definition after creation for status reporting |
| tools/pkg/virtdeploy/namespace.go | Added serialPoolName helper method (unused in this diff) |
| tools/pkg/virtdeploy/config.go | Added domainDefinition field to VirtDeployVM struct |
| tools/pkg/ref/ref.go | Added IsNilInterface utility to safely check for nil interface values |
| tools/go.mod | Updated storm dependency to v0.4.0-alpha1 |
| tools/go.sum | Updated checksums for storm v0.4.0-alpha1 and related dependencies |
| .pipelines/templates/stages/testing_e2e/test_execution_template.yml | Added output directory flag to storm-trident command |
ndubchak
reviewed
Dec 29, 2025
ndubchak
previously approved these changes
Dec 29, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bfjelds
reviewed
Jan 5, 2026
bfjelds
reviewed
Jan 5, 2026
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Depends on microsoft/storm#13 (and subsequent release)
Adds code to connect to the libvirt console in the background and scan it live to have debug output in an artifact.