[rush] Update the functionality that runs external lifecycle processes to be async. #4350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
D4N14L,
apostolisms,
dmichon-msft and
octogonz
as code owners
D4N14L
reviewed
Sep 27, 2023
iclanton
force-pushed
the
refactor-executeCommand
branch
2 times, most recently
from
e853889 to
a16f097
Compare
D4N14L
reviewed
Mar 30, 2024
iclanton
force-pushed
the
refactor-executeCommand
branch
2 times, most recently
from
0062d82 to
ebe2934
Compare
iclanton
force-pushed
the
refactor-executeCommand
branch
3 times, most recently
from
0b6cad6 to
8b18bd0
Compare
D4N14L
approved these changes
Jun 2, 2024
iclanton
force-pushed
the
refactor-executeCommand
branch
from
f293a1a to
0ae6962
Compare
iclanton
force-pushed
the
refactor-executeCommand
branch
from
0ae6962 to
a10b6f3
Compare
D4N14L
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
executeCommandand related functions to be async. This is in preparation for some follow-up work to mergeexecuteCommandAndProcessOutputWithRetryAsyncinto theexecuteCommandAsyncfunction.How it was tested
This change needs some more testing.