Update the cpp-lib template project to support importing either paper Uwp or fabric Composition prop/targets
#13945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR creates new "entry" prop/target imports for C++ libraries that depend on the `UseFabric` property to conditionally import either the old Uwp props/targets or the new Composition props/targets. Resolves microsoft#13928.
microsoft-github-policy-service
bot
added
Area: Library Template
New Architecture
Contributor
Author
|
This will need to be backported in full to 0.76 and at least the presence of the prop/target sheets in 0.75 and 0.74. |
chrisglein
approved these changes
Oct 9, 2024
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Oct 23, 2024
…her paper Uwp or fabric Composition prop/targets This PR backports microsoft#13945 to 0.76. ## Description This PR creates new "entry" prop/target imports for C++ libraries that depend on the `UseFabric` property to conditionally import either the old Uwp props/targets or the new Composition props/targets. ### Type of Change - New feature (non-breaking change which adds functionality) ### Why This helps enable module projects to support both paper and fabric with the same build files. Resolves microsoft#13928. ### What Added new imports, updated the `cpp-lib` template and existing sample to load them. ## Screenshots N/A ## Testing N/A ## Changelog Should this change be included in the release notes: yes Update the `cpp-lib` template project to support importing either paper Uwp or fabric Composition prop/targets
jonthysell
added a commit
that referenced
this pull request
Oct 24, 2024
…her paper Uwp or fabric Composition prop/targets (#14024) This PR backports #13945 to 0.76. ## Description This PR creates new "entry" prop/target imports for C++ libraries that depend on the `UseFabric` property to conditionally import either the old Uwp props/targets or the new Composition props/targets. ### Type of Change - New feature (non-breaking change which adds functionality) ### Why This helps enable module projects to support both paper and fabric with the same build files. Resolves #13928. ### What Added new imports, updated the `cpp-lib` template and existing sample to load them. ## Screenshots N/A ## Testing N/A ## Changelog Should this change be included in the release notes: yes Update the `cpp-lib` template project to support importing either paper Uwp or fabric Composition prop/targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates new "entry" prop/target imports for C++ libraries that depend on the
UseFabricproperty to conditionally import either the old Uwp props/targets or the new Composition props/targets.Type of Change
Why
This helps enable module projects to support both paper and fabric with the same build files.
Resolves #13928.
What
Added new imports, updated the
cpp-libtemplate and existing sample to load them.Screenshots
N/A
Testing
N/A
Changelog
Should this change be included in the release notes: yes
Update the
cpp-libtemplate project to support importing either paper Uwp or fabric Composition prop/targetsMicrosoft Reviewers: Open in CodeFlow