Skip to content

Commit 919860a

Browse files
acoates-msanupriya13iamAbhi-916vineethkuttanVineeth K
authored
[0.74] Cherry picking various fixes (#15142)
* Pointer events (#14713) * PointerEvent fixes * Change files * format * [Fabric] Implement SpellCheck and AutoCorrect for TextInput (#14509) * Fabric : Added support for selectionColor in TextInput component (#14743) * Added support for selectionColor for textInput * yarn fix and format * Change files * Implement adjustsFontSizeToFit property for Text in Fabric (#14519) * Implementation of adjustFontSizeToFit * Final Changes using TextLayout * Lint Issue Fixes * Change files * prop change detection added * review Changes and E2E test cases added * Lint and Format Changes added * Test Cases Fix added * Update SnapShot * Removed the additional Check for resizing Font * Updated SnapShot * Review Changes * Lint and Format Changes --------- Co-authored-by: Vineeth K <[email protected]> * Text : Added EllipsizeMode for tail and clip alignment (#14660) * updated ellipsis to respect tail and clip behaviour , for head , middle follow defaulty tail behaviour * patched updateTextAlignment method * Change files * pathced branch , lint fix , lint format * updated snapshots * added layout changes to TextLayoutManager * lint fix and format * updated snapshots * updated snapshot Pressable component * updated to remove extra text_layout null check * removed comments * format and lint:fix * [Fabric] Implement onContentSizeChange in TextInput (#14785) * Fix : adjustsFontSizeToFit just redrawing won't recalculate the layout (#14813) * updated adjustsFontSizeToFit textlayout to nullptr * Change files * [Fabric] Implement autoFocus property for TextInput for fabric (#14816) * Added fix for AutoFocus * Change files --------- Co-authored-by: Harini Malothu <[email protected]> * [Fabric] Implementation of accessibilityDescription (#14818) * Initial Commit for accessibilityDescription * Change files * Format Changes * Updating Snapshot * [Fabric] Implement maxFontSizeMultiplier in Text Input (#14639) * [Fabric] Fix for updating accessibility value in UIA (#14858) * Changes for updating accessibilityValue prop * Change files * TextInput should capture mouse on mouse down (#14983) * TextInput should capture mouse on mouse down * Change files * format * [Fabric] Raising UIA Event if Toggle State Changes in Switch Component (#15023) * Update Toggle State to Narrator * Yarn Change * Review Changes * Review Changes 2.0 * [Fabric] Add Support for ITextProvider, ITextProvider2, and ITextRangeProvider (#14332) * Partial Implementation * Add More Implementation * More Implementation * More Implementation * Add Support for Bounding Rectangles * Complete Initial Implementation * Change files * Code Cleanup * Code Cleanup * Update Snapshots + Code Cleanup * Update Snapshots * Address Feedback * Address Feedback * Update Snapshots * Fix Tests --------- Co-authored-by: Jon Thysell <[email protected]> * [Fabric] Fix for Text and TextInput focus issue with screen readers (#15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file * Screen reader fails to announce the expand/collapse state of the navigation button (#15106) * adding UIA event handler changes for navigator * Change files * adding ViewComponent chnages for accessibility * removing unnecessary change file * Remove vnext/fmt/packages.lock.json --------- Co-authored-by: Protik Biswas <[email protected]> * fix * fix * Upgrade dotnet version * Change files * bump sdk * bump node * fix * fix * Change files * fix * fix * test * fix * fix * update snapshots * snapshot * snapshot * measureLines * fix * snapshot --------- Co-authored-by: Anupriya Verma <[email protected]> Co-authored-by: Abhijeet Jha <[email protected]> Co-authored-by: Vineeth <[email protected]> Co-authored-by: Vineeth K <[email protected]> Co-authored-by: Harini Malothu <[email protected]> Co-authored-by: Harini Malothu <[email protected]> Co-authored-by: Chiara Mooney <[email protected]> Co-authored-by: Jon Thysell <[email protected]> Co-authored-by: Protik Biswas <[email protected]> Co-authored-by: Protik Biswas <[email protected]>
1 parent 8cd904e commit 919860a

File tree

98 files changed

+2581
-444
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+2581
-444
lines changed

.ado/compliance.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ parameters:
66
default:
77
Medium:
88
name: rnw-pool-4-microsoft
9-
demands: ImageOverride -equals rnw-img-vs2022-node18
9+
demands: ImageOverride -equals rnw-img-vs2022-node22
1010
Large:
1111
name: rnw-pool-8-microsoft
12-
demands: ImageOverride -equals rnw-img-vs2022-node18
12+
demands: ImageOverride -equals rnw-img-vs2022-node22
1313
- name: forceCodeQL
1414
displayName: Force CodeQL to rebuild databases
1515
type: boolean

.ado/continuous.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ parameters:
1313
default:
1414
Small:
1515
name: rnw-pool-2
16-
demands: ImageOverride -equals rnw-img-vs2022-node18
16+
demands: ImageOverride -equals rnw-img-vs2022-node22
1717
Medium:
1818
name: rnw-pool-4
19-
demands: ImageOverride -equals rnw-img-vs2022-node18
19+
demands: ImageOverride -equals rnw-img-vs2022-node22
2020
Large:
2121
name: rnw-pool-8
22-
demands: ImageOverride -equals rnw-img-vs2022-node18
22+
demands: ImageOverride -equals rnw-img-vs2022-node22
2323

2424
stages:
2525
- template: stages.yml

.ado/jobs/macos-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ jobs:
1414
- template: ../templates/prepare-js-env.yml
1515
parameters:
1616
agentImage: HostedImage
17+
fixupCommands: false
1718

1819
- script: yarn test
1920
displayName: yarn test

.ado/jobs/node-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ parameters:
1212

1313
- name: versions
1414
type: object
15-
default: [18]
15+
default: [22]
1616

1717
jobs:
1818
- ${{ each nodeVersion in parameters.versions }}:

.ado/jobs/setup.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ jobs:
1414
pool: {vmImage: ubuntu-latest}
1515

1616
steps:
17+
- task: UseNode@1
18+
inputs:
19+
version: '22.14.0'
20+
displayName: 'Use Node.js 22.14.0'
21+
1722
- template: ../templates/checkout-full.yml
1823
parameters:
1924
persistCredentials: true # Git creds needed for beachball

.ado/publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ parameters:
2222
default:
2323
Medium:
2424
name: rnw-pool-4-microsoft
25-
demands: ImageOverride -equals rnw-img-vs2022-node18
25+
demands: ImageOverride -equals rnw-img-vs2022-node22
2626
Large:
2727
name: rnw-pool-8-microsoft
28-
demands: ImageOverride -equals rnw-img-vs2022-node18
28+
demands: ImageOverride -equals rnw-img-vs2022-node22
2929

3030
- name: desktopBuildMatrix
3131
type: object

.ado/scripts/npmAddUser.js

Lines changed: 53 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// @ts-check
33

44
const child_process = require("child_process");
5+
const fs = require("fs");
6+
const path = require("path");
7+
const os = require("os");
58

69
const username = process.argv[2];
710
const password = process.argv[3];
@@ -23,18 +26,54 @@ if (!email) {
2326
process.exit(1);
2427
}
2528

26-
const child = child_process.exec(`npm adduser${registry? (' --registry ' + registry) :''}` );
27-
28-
child.stdout.on("data", d => {
29-
const data = d.toString();
30-
process.stdout.write(d + "\n");
31-
if (data.match(/username/i)) {
32-
child.stdin.write(username + "\n");
33-
} else if (data.match(/password/i)) {
34-
child.stdin.write(password + "\n");
35-
} else if (data.match(/email/i)) {
36-
child.stdin.write(email + "\n");
37-
} else if (data.match(/logged in as/i)) {
38-
child.stdin.end();
39-
}
29+
const registryUrl = registry || "http://localhost:4873";
30+
31+
// First set the registry
32+
console.log(`Setting npm registry to ${registryUrl}`);
33+
const setRegistry = child_process.spawnSync('npm', ['config', 'set', 'registry', registryUrl], {
34+
stdio: 'inherit',
35+
shell: true
4036
});
37+
38+
if (setRegistry.status !== 0) {
39+
console.error('Failed to set registry');
40+
process.exit(1);
41+
}
42+
43+
// Create auth token for verdaccio
44+
const authString = Buffer.from(`${username}:${password}`).toString('base64');
45+
const registryPath = registryUrl.replace(/^https?:/, '');
46+
47+
// Set auth in npm config
48+
console.log('Setting authentication...');
49+
const setAuth = child_process.spawnSync('npm', ['config', 'set', `${registryPath}/:_auth`, authString], {
50+
stdio: 'inherit',
51+
shell: true
52+
});
53+
54+
if (setAuth.status !== 0) {
55+
console.error('Failed to set auth');
56+
process.exit(1);
57+
}
58+
59+
// Set email
60+
const setEmail = child_process.spawnSync('npm', ['config', 'set', 'email', email], {
61+
stdio: 'inherit',
62+
shell: true
63+
});
64+
65+
// Verify authentication
66+
console.log('Verifying authentication...');
67+
const whoami = child_process.spawnSync('npm', ['whoami', '--registry', registryUrl], {
68+
encoding: 'utf8',
69+
shell: true
70+
});
71+
72+
if (whoami.status === 0 && whoami.stdout.trim()) {
73+
console.log(`Logged in as ${whoami.stdout.trim()} on ${registryUrl}`);
74+
process.exit(0);
75+
} else {
76+
console.error('Authentication verification failed');
77+
if (whoami.stderr) console.error('Error:', whoami.stderr);
78+
process.exit(1);
79+
}

.ado/templates/prepare-js-env.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,20 @@ parameters:
55
values:
66
- ManagedImage
77
- HostedImage
8-
8+
- name: fixupCommands
9+
type: boolean
10+
default: true
911
steps:
1012
- ${{ if eq(parameters.agentImage, 'HostedImage') }}:
1113
- task: NodeTool@0
1214
displayName: Set Node Version
1315
inputs:
14-
versionSpec: '18.x'
16+
versionSpec: '22.x'
1517

1618
- template: yarn-install.yml
1719
parameters:
1820
agentImage: ${{ parameters.agentImage }}
21+
fixupCommands: ${{ parameters.fixupCommands }}
1922

2023
- script: yarn build
2124
displayName: yarn build

.ado/templates/yarn-install.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ parameters:
88
values:
99
- ManagedImage
1010
- HostedImage
11+
- name: fixupCommands
12+
type: boolean
13+
default: true
1114

1215
steps:
1316
# When using our own images, prefer the machine-installed version of
@@ -21,3 +24,6 @@ steps:
2124
- ${{ else }}:
2225
- script: npx --yes [email protected] --ignore-scripts --frozen-lockfile --cwd ${{ parameters.workingDirectory }}
2326
displayName: midgard-yarn (faster yarn install)
27+
28+
- ${{ if eq(parameters.fixupCommands, true) }}:
29+
- script: npx -y [email protected] --path vnext/node_modules/.bin

.ado/windows-vs-pr-secure.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ parameters:
1616
default:
1717
Small:
1818
name: rnw-pool-2
19-
demands: ImageOverride -equals rnw-img-vs2022-node18
19+
demands: ImageOverride -equals rnw-img-vs2022-node22
2020
Medium:
2121
name: rnw-pool-4
22-
demands: ImageOverride -equals rnw-img-vs2022-node18
22+
demands: ImageOverride -equals rnw-img-vs2022-node22
2323
Large:
2424
name: rnw-pool-8
25-
demands: ImageOverride -equals rnw-img-vs2022-node18
25+
demands: ImageOverride -equals rnw-img-vs2022-node22
2626

2727
stages:
2828
- template: stages.yml

0 commit comments

Comments
 (0)