Skip to content

Commit 8cd904e

Browse files
authored
[0.74] Disable SBOM in Non-Production ADO Pipelines (#14781)
This PR backports PR #14775 to RNW 0.74. ## Description This removes the creation of SBOM manifests in our CI/PR pipelines, as it is no longer possible to create them unsigned. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why Our non-production ADO pipelines (CI/PR) do not need to create SBOMS, but we were doing so anyway. But since they didn't have permission to sign the SBOMs, we disabled that and create unsigned ones instead. This no longer works, and so all CI/PR are failing, blocking all codeflow. Closes #14774 ### What Removed SBOM tasks that ran in CI/PR. ## Screenshots N/A ## Testing N/A ## Changelog Should this change be included in the release notes: _no_
1 parent 41fb04b commit 8cd904e

File tree

3 files changed

+27
-34
lines changed

3 files changed

+27
-34
lines changed

.ado/stages.yml

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,20 @@ stages:
3434
parameters:
3535
buildEnvironment: ${{ parameters.buildEnvironment }}
3636
AgentPool: ${{ parameters.AgentPool }}
37-
38-
- template: jobs/cli-init-windows.yml
39-
parameters:
40-
buildEnvironment: ${{ parameters.buildEnvironment }}
41-
AgentPool: ${{ parameters.AgentPool }}
42-
buildNuGetOnly: true
4337

44-
# NuGet using tests rely on "UniversalBuild" which is done in the build stage
45-
- template: jobs/cli-init.yml
46-
parameters:
47-
buildEnvironment: ${{ parameters.buildEnvironment }}
48-
AgentPool: ${{ parameters.AgentPool }}
49-
buildNuGetOnly: true
38+
# Disabling CLI Stage as branch is Unsupported, see https://microsoft.github.io/react-native-windows/support
39+
# - template: jobs/cli-init-windows.yml
40+
# parameters:
41+
# buildEnvironment: ${{ parameters.buildEnvironment }}
42+
# AgentPool: ${{ parameters.AgentPool }}
43+
# buildNuGetOnly: true
44+
45+
# # NuGet using tests rely on "UniversalBuild" which is done in the build stage
46+
# - template: jobs/cli-init.yml
47+
# parameters:
48+
# buildEnvironment: ${{ parameters.buildEnvironment }}
49+
# AgentPool: ${{ parameters.AgentPool }}
50+
# buildNuGetOnly: true
5051

5152
- stage: IntegrationTests
5253
displayName: Tests 🧪
@@ -84,18 +85,18 @@ stages:
8485
buildEnvironment: ${{ parameters.buildEnvironment }}
8586
AgentPool: ${{ parameters.AgentPool }}
8687

87-
- stage: CLI
88-
displayName: Cli 🖥
89-
dependsOn: Setup
90-
jobs:
91-
- template: jobs/cli-init.yml
92-
parameters:
93-
buildEnvironment: ${{ parameters.buildEnvironment }}
94-
AgentPool: ${{ parameters.AgentPool }}
95-
buildNuGetOnly: false
88+
# Disabling CLI Stage as branch is Unsupported, see https://microsoft.github.io/react-native-windows/support
89+
# - stage: CLI
90+
# displayName: Cli 🖥
91+
# dependsOn: Setup
92+
# jobs:
93+
# - template: jobs/cli-init.yml
94+
# parameters:
95+
# buildEnvironment: ${{ parameters.buildEnvironment }}
96+
# AgentPool: ${{ parameters.AgentPool }}
97+
# buildNuGetOnly: false
9698

97-
- template: jobs/cli-init-windows.yml
98-
parameters:
99-
buildEnvironment: ${{ parameters.buildEnvironment }}
100-
AgentPool: ${{ parameters.AgentPool }}
101-
buildNuGetOnly: false
99+
# - template: jobs/cli-init-windows.yml
100+
# parameters:
101+
# buildEnvironment: ${{ parameters.buildEnvironment }}
102+
# AgentPool: ${{ parameters.AgentPool }}

.ado/templates/publish-build-artifacts.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ steps:
2222
contents: ${{parameters.contents}}
2323

2424
- ${{ if not(parameters.oneESMode) }}:
25-
- task: AzureArtifacts.manifest-generator-task.manifest-generator-task.ManifestGeneratorTask@0
26-
displayName: "📒 Generate Manifest: ${{parameters.artifactName}}.${{parameters.buildPlatform}}.${{parameters.buildConfiguration}}"
27-
inputs:
28-
BuildDropPath: $(Build.StagingDirectory)/NuGet/${{ parameters.artifactName }}/${{ parameters.buildPlatform }}/${{ parameters.buildConfiguration }}
29-
3025
- task: PublishPipelineArtifact@1
3126
displayName: "Publish Artifact: ${{parameters.artifactName}}.${{parameters.buildPlatform}}.${{parameters.buildConfiguration}}"
3227
# Do nothing if the artifact was already published. E.g. after rerunning a past successful job attempt

.ado/variables/shared.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ variables:
55
runCodesignValidationInjection: false
66
skipComponentGovernanceDetection: true
77

8-
# SBOM signing only works on microsoft ADO
9-
Packaging.EnableSBOMSigning: ${{ startsWith(variables['System.CollectionUri'], 'https://dev.azure.com/microsoft') }}
10-
118
# Enables `chalk` to show colored output to Azure Pipelines
129
FORCE_COLOR: 3
1310

0 commit comments

Comments
 (0)