Skip to content

fix(android): navigate if ReactContext is already initialized #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix(android): navigate if ReactContext is already initialized #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion android/app/src/main/java/com/microsoft/reacttestapp/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import androidx.recyclerview.widget.DividerItemDecoration
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import com.facebook.react.ReactActivity
import com.facebook.react.bridge.ReactContext
import com.facebook.react.modules.systeminfo.ReactNativeVersion
import com.google.android.material.appbar.MaterialToolbar
import com.microsoft.reacttestapp.component.ComponentActivity
Expand Down Expand Up @@ -79,11 +80,15 @@ class MainActivity : ReactActivity() {
if (manifest.components.count() == 1) 0 else session.lastOpenedComponent(checksum)
index?.let {
val component = newComponentViewModel(manifest.components[it])
testApp.reactNativeHost.addReactInstanceEventListener {
val startInitialComponent = { _: ReactContext ->
if (!didInitialNavigation) {
startComponent(component)
}
}
testApp.reactNativeHost.apply {
addReactInstanceEventListener(startInitialComponent)
reactInstanceManager.currentReactContext?.let(startInitialComponent)
}
}

setupToolbar(manifest.displayName)
Expand Down