Skip to content

fix: declare support for 0.73 #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: declare support for 0.73 #1690

merged 2 commits into from
Nov 30, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 8, 2023 •
edited
Loading

Description

Declares support for 0.73.

Resolves #1637.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

./scripts/test-matrix.sh 0.73

Screenshots

Configuration Android iOS
JSC n/a Screenshot-iOS
Hermes Screenshot-Android-hermes Screenshot-iOS-hermes
Fabric n/a Screenshot-iOS-fabric
Fabric + Hermes Screenshot-Android-hermes-fabric Screenshot-iOS-hermes-fabric

@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels Nov 8, 2023
@tido64 tido64 force-pushed the tido/0.73 branch 2 times, most recently from 9182595 to f800a35 Compare November 21, 2023 14:44
@github-actions github-actions bot added the platform: Android This affects Android label Nov 29, 2023
kelset
kelset approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all working as expected, and all changes LGTM 👍

Let's 🚢

@tido64 tido64 merged commit f2601e7 into trunk Nov 30, 2023
@tido64 tido64 deleted the tido/0.73 branch November 30, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-un tom-un Awaiting requested review from tom-un

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

@arazabishov arazabishov Awaiting requested review from arazabishov

@sweggersen sweggersen Awaiting requested review from sweggersen

1 more reviewer

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for react-native 0.73

2 participants

@tido64 @kelset