Skip to content

fix(windows): fix random Windows build failure #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix(windows): fix random Windows build failure #1235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions windows/test-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,21 @@ function generateSolution(destPath, { autolink, useHermes, useNuGet }) {
});
}

// TODO: Remove when we drop support for 0.69.
// Patch building with Visual Studio 2022. For more details, see
// https://github.com/microsoft/react-native-windows/pull/10373
if (rnWindowsVersionNumber < 7000) {
const helpers = path.join(
rnWindowsPath,
"Microsoft.ReactNative",
"Utils",
"Helpers.h"
);
copyAndReplace(helpers, helpers, {
"inline typename T asEnum": "inline T asEnum",
});
}

if (useNuGet) {
const nugetConfigPath =
findNearest(
Expand Down