Skip to content

fix: add missing text inputs in macOS Configure Bundler dialog #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2025
+83 −7
Merged

fix: add missing text inputs in macOS Configure Bundler dialog #2747

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8eb316c
Initial plan
Copilot Oct 31, 2025
e47ad76
Add text input fields to macOS Configure Bundler dialog
Copilot Oct 31, 2025
94a166a
Add clarifying comments to bundler configuration logic
Copilot Oct 31, 2025
507e6f2
Remove formatting-only change from unrelated code
Copilot Oct 31, 2025
e0824a4
Refactor to share bundler configuration logic between iOS and macOS
Copilot Nov 1, 2025
673ab7c
Restore original iOS code, only modify macOS section
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 83 additions & 7 deletions packages/react-native/React/CoreModules/RCTDevMenu.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,74 @@ - (void)setDefaultJSBundle
NSAlert *alert = [NSAlert new];
[alert setMessageText:@"Change packager location"];
[alert setInformativeText:@"Input packager IP, port and entrypoint"];
[alert addButtonWithTitle:@"Use bundled JS"];

// Create accessory view with text fields
NSView *accessoryView = [[NSView alloc] initWithFrame:NSMakeRect(0.0, 0.0, 300.0, 90.0)];

// IP Address text field
NSTextField *ipTextField = [[NSTextField alloc] initWithFrame:NSMakeRect(0.0, 60.0, 300.0, 22.0)];
ipTextField.placeholderString = @"0.0.0.0";
ipTextField.cell.scrollable = YES;
[accessoryView addSubview:ipTextField];

// Port text field
NSTextField *portTextField =
[[NSTextField alloc] initWithFrame:NSMakeRect(0.0, 30.0, 300.0, 22.0)];
portTextField.placeholderString = @"8081";
portTextField.cell.scrollable = YES;
[accessoryView addSubview:portTextField];

// Entrypoint text field
NSTextField *entrypointTextField =
[[NSTextField alloc] initWithFrame:NSMakeRect(0.0, 0.0, 300.0, 22.0)];
entrypointTextField.placeholderString = @"index";
entrypointTextField.cell.scrollable = YES;
[accessoryView addSubview:entrypointTextField];

alert.accessoryView = accessoryView;

[alert addButtonWithTitle:@"Apply Changes"];
[alert addButtonWithTitle:@"Reset to Default"];
[alert addButtonWithTitle:@"Cancel"];
[alert setAlertStyle:NSAlertStyleWarning];
[alert beginSheetModalForWindow:[NSApp keyWindow] completionHandler:nil];

[alert beginSheetModalForWindow:[NSApp keyWindow]
completionHandler:^(NSModalResponse response) {
if (response == NSAlertFirstButtonReturn) {
// Apply Changes
NSString *ipAddress = ipTextField.stringValue;
NSString *port = portTextField.stringValue;
NSString *bundleRoot = entrypointTextField.stringValue;

if (ipAddress.length == 0 && port.length == 0) {
[weakSelf setDefaultJSBundle];
return;
}

NSNumberFormatter *formatter = [NSNumberFormatter new];
formatter.numberStyle = NSNumberFormatterDecimalStyle;
NSNumber *portNumber = [formatter numberFromString:port];
if (portNumber == nil) {
portNumber = [NSNumber numberWithInt:RCT_METRO_PORT];
}

[RCTBundleURLProvider sharedSettings].jsLocation =
[NSString stringWithFormat:@"%@:%d", ipAddress, portNumber.intValue];

if (bundleRoot.length == 0) {
[bundleManager resetBundleURL];
} else {
bundleManager.bundleURL = [[RCTBundleURLProvider sharedSettings]
jsBundleURLForBundleRoot:bundleRoot];
}

RCTTriggerReloadCommandListeners(@"Dev menu - apply changes");
} else if (response == NSAlertSecondButtonReturn) {
// Reset to Default
[weakSelf setDefaultJSBundle];
}
// Cancel - do nothing
}];
#endif // macOS]
}]];

Expand Down Expand Up @@ -452,7 +517,15 @@ - (void)setDefaultJSBundle
#else // [macOS
NSMenu *menu = [self menu];
NSWindow *window = [NSApp keyWindow];
NSEvent *event = [NSEvent mouseEventWithType:NSEventTypeLeftMouseUp location:CGPointMake(0, 0) modifierFlags:0 timestamp:NSTimeIntervalSince1970 windowNumber:[window windowNumber] context:nil eventNumber:0 clickCount:0 pressure:0.1];
NSEvent *event = [NSEvent mouseEventWithType:NSEventTypeLeftMouseUp
location:CGPointMake(0, 0)
modifierFlags:0
timestamp:NSTimeIntervalSince1970
windowNumber:[window windowNumber]
context:nil
eventNumber:0
clickCount:0
pressure:0.1];
[NSMenu popUpContextMenu:menu withEvent:event forView:[window contentView]];
#endif // macOS]

Expand Down Expand Up @@ -484,8 +557,9 @@ - (NSMenu *)menu

menu = [NSMenu new];

NSMutableAttributedString *attributedTitle = [[NSMutableAttributedString alloc]initWithString:title];
[attributedTitle setAttributes: @{ NSFontAttributeName : [NSFont menuFontOfSize:0] } range: NSMakeRange(0, [attributedTitle length])];
NSMutableAttributedString *attributedTitle = [[NSMutableAttributedString alloc] initWithString:title];
[attributedTitle setAttributes:@{NSFontAttributeName : [NSFont menuFontOfSize:0]}
range:NSMakeRange(0, [attributedTitle length])];
NSMenuItem *titleItem = [NSMenuItem new];
[titleItem setAttributedTitle:attributedTitle];
[menu addItem:titleItem];
Expand All @@ -494,7 +568,9 @@ - (NSMenu *)menu

NSArray<RCTDevMenuItem *> *items = [self _menuItemsToPresent];
for (RCTDevMenuItem *item in items) {
NSMenuItem *menuItem = [[NSMenuItem alloc] initWithTitle:[item title] action:@selector(menuItemSelected:) keyEquivalent:@""];
NSMenuItem *menuItem = [[NSMenuItem alloc] initWithTitle:[item title]
action:@selector(menuItemSelected:)
keyEquivalent:@""];
[menuItem setTarget:self];
[menuItem setRepresentedObject:item];
[menu addItem:menuItem];
Expand All @@ -505,7 +581,7 @@ - (NSMenu *)menu
return nil;
}

-(void)menuItemSelected:(id)sender
- (void)menuItemSelected:(id)sender
{
NSMenuItem *menuItem = (NSMenuItem *)sender;
RCTDevMenuItem *item = (RCTDevMenuItem *)[menuItem representedObject];
Expand Down
Loading